chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.cc - Issue 12079097: Introduce PrefRegistrySyncable, simplifying PrefServiceSyncable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.cc

Issue 12079097: Introduce PrefRegistrySyncable, simplifying PrefServiceSyncable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add to PrefRegistrySyncable and PrefServiceSyncable to let sync know of pre-registered prefs. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app.cc ('K') | « chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app.cc ('k') | chrome/browser/ui/browser_instant_controller.h » ('j') | chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.cc

diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.cc b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.cc

index 3ae0e4e36744ad79abb2246d777c7781405a3737..a82744445f2c0d4591dc10d997b85f2461273209 100644

--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.cc

+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.cc

@@ -17,7 +17,7 @@

#include "chrome/browser/extensions/extension_service.h"

#include "chrome/browser/extensions/extension_system.h"

#include "chrome/browser/prefs/incognito_mode_prefs.h"

-#include "chrome/browser/prefs/pref_service.h"

+#include "chrome/browser/prefs/pref_service_syncable.h"

#include "chrome/browser/prefs/scoped_user_pref_update.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/profiles/profile_manager.h"

@@ -275,7 +275,7 @@ ChromeLauncherControllerPerBrowser::~ChromeLauncherControllerPerBrowser() {

if (app_sync_ui_state_)

app_sync_ui_state_->RemoveObserver(this);

- profile_->GetPrefs()->RemoveObserver(this);

+ PrefServiceSyncable::FromProfile(profile_)->RemoveObserver(this);

}

void ChromeLauncherControllerPerBrowser::Init() {

@@ -285,7 +285,7 @@ void ChromeLauncherControllerPerBrowser::Init() {

if (ash::Shell::HasInstance()) {

SetShelfAutoHideBehaviorFromPrefs();

SetShelfAlignmentFromPrefs();

- PrefServiceSyncable* prefs = profile_->GetPrefs();

+ PrefServiceSyncable* prefs = PrefServiceSyncable::FromProfile(profile_);

if (!prefs->FindPreference(prefs::kShelfAlignmentLocal)->HasUserSetting() ||

!prefs->FindPreference(prefs::kShelfAutoHideBehaviorLocal)->

HasUserSetting()) {

@@ -945,10 +945,11 @@ void ChromeLauncherControllerPerBrowser::OnShelfAlignmentChanged(

}

void ChromeLauncherControllerPerBrowser::OnIsSyncingChanged() {

- MaybePropagatePrefToLocal(profile_->GetPrefs(),

+ PrefServiceSyncable* prefs = PrefServiceSyncable::FromProfile(profile_);

+ MaybePropagatePrefToLocal(prefs,

prefs::kShelfAlignmentLocal,

prefs::kShelfAlignment);

- MaybePropagatePrefToLocal(profile_->GetPrefs(),

+ MaybePropagatePrefToLocal(prefs,

prefs::kShelfAutoHideBehaviorLocal,

prefs::kShelfAutoHideBehavior);

}