Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5643)

Unified Diff: chrome/browser/profiles/profile_impl.h

Issue 12079097: Introduce PrefRegistrySyncable, simplifying PrefServiceSyncable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add to PrefRegistrySyncable and PrefServiceSyncable to let sync know of pre-registered prefs. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/profile_impl.h
diff --git a/chrome/browser/profiles/profile_impl.h b/chrome/browser/profiles/profile_impl.h
index 87d2c1d4f7bf1b5ffc7f943a9abd369cb169e4dc..29e3809ea8259a9baa67d7c7caf0e937bae1d4d0 100644
--- a/chrome/browser/profiles/profile_impl.h
+++ b/chrome/browser/profiles/profile_impl.h
@@ -21,8 +21,10 @@
#include "content/public/browser/notification_registrar.h"
class NetPrefObserver;
-class PrefServiceSyncable;
+class PrefRegistrySyncable;
+class PrefService;
class PrefServiceBase;
+class PrefServiceSyncable;
class SSLConfigServiceManager;
#if defined(OS_CHROMEOS)
@@ -58,7 +60,7 @@ class ProfileImpl : public Profile,
virtual ~ProfileImpl();
- static void RegisterUserPrefs(PrefServiceSyncable* prefs);
+ static void RegisterUserPrefs(PrefRegistrySyncable* registry);
// content::BrowserContext implementation:
virtual FilePath GetPath() OVERRIDE;
@@ -100,8 +102,8 @@ class ProfileImpl : public Profile,
virtual policy::ManagedModePolicyProvider*
GetManagedModePolicyProvider() OVERRIDE;
virtual policy::PolicyService* GetPolicyService() OVERRIDE;
- virtual PrefServiceSyncable* GetPrefs() OVERRIDE;
- virtual PrefServiceSyncable* GetOffTheRecordPrefs() OVERRIDE;
+ virtual PrefService* GetPrefs() OVERRIDE;
+ virtual PrefService* GetOffTheRecordPrefs() OVERRIDE;
virtual net::URLRequestContextGetter*
GetRequestContextForExtensions() OVERRIDE;
virtual net::SSLConfigService* GetSSLConfigService() OVERRIDE;
@@ -216,6 +218,7 @@ class ProfileImpl : public Profile,
// Keep |prefs_| on top for destruction order because |extension_prefs_|,
// |net_pref_observer_|, |io_data_| an others store pointers to |prefs_| and
// shall be destructed first.
+ scoped_refptr<PrefRegistrySyncable> pref_registry_;
scoped_ptr<PrefServiceSyncable> prefs_;
scoped_ptr<PrefServiceSyncable> otr_prefs_;
ProfileImplIOData::Handle io_data_;

Powered by Google App Engine
This is Rietveld 408576698