Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4887)

Unified Diff: chrome/browser/profiles/profile.h

Issue 12079097: Introduce PrefRegistrySyncable, simplifying PrefServiceSyncable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add to PrefRegistrySyncable and PrefServiceSyncable to let sync know of pre-registered prefs. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/profile.h
diff --git a/chrome/browser/profiles/profile.h b/chrome/browser/profiles/profile.h
index 40ca85de73bb64ed48b0636ff06803141ee44de5..0e952a5221639f6e254d48308012a8b6adcf4667 100644
--- a/chrome/browser/profiles/profile.h
+++ b/chrome/browser/profiles/profile.h
@@ -21,7 +21,7 @@ class ExtensionSpecialStoragePolicy;
class FaviconService;
class HostContentSettingsMap;
class PasswordStore;
-class PrefServiceSyncable;
+class PrefRegistrySyncable;
class PromoCounter;
class ProtocolHandlerRegistry;
class TestingProfile;
@@ -135,7 +135,7 @@ class Profile : public content::BrowserContext {
// Profile prefs are registered as soon as the prefs are loaded for the first
// time.
- static void RegisterUserPrefs(PrefServiceSyncable* prefs);
+ static void RegisterUserPrefs(PrefRegistrySyncable* registry);
// Gets task runner for I/O operations associated with |profile|.
static scoped_refptr<base::SequencedTaskRunner> GetTaskRunnerForProfile(
@@ -208,15 +208,14 @@ class Profile : public content::BrowserContext {
// Returns the PolicyService that provides policies for this profile.
virtual policy::PolicyService* GetPolicyService() = 0;
- // Retrieves a pointer to the PrefServiceSyncable that manages the preferences
- // for this user profile.
- // TODO(joi): Make this and the below return just a PrefService.
- virtual PrefServiceSyncable* GetPrefs() = 0;
+ // Retrieves a pointer to the PrefService that manages the
+ // preferences for this user profile.
+ virtual PrefService* GetPrefs() = 0;
// Retrieves a pointer to the PrefService that manages the preferences
// for OffTheRecord Profiles. This PrefService is lazily created the first
// time that this method is called.
- virtual PrefServiceSyncable* GetOffTheRecordPrefs() = 0;
+ virtual PrefService* GetOffTheRecordPrefs() = 0;
// Returns the main request context.
virtual net::URLRequestContextGetter* GetRequestContext() = 0;

Powered by Google App Engine
This is Rietveld 408576698