chrome/browser/profiles/gaia_info_update_service_factory.cc - Issue 12079097: Introduce PrefRegistrySyncable, simplifying PrefServiceSyncable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/profiles/gaia_info_update_service_factory.cc

Issue 12079097: Introduce PrefRegistrySyncable, simplifying PrefServiceSyncable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add to PrefRegistrySyncable and PrefServiceSyncable to let sync know of pre-registered prefs. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/profiles/gaia_info_update_service_factory.cc

diff --git a/chrome/browser/profiles/gaia_info_update_service_factory.cc b/chrome/browser/profiles/gaia_info_update_service_factory.cc

index fd3ffb2605d590565e8484fc20b297edb48a07ae..245f36f6a9183882c4babe17977517df7243823b 100644

--- a/chrome/browser/profiles/gaia_info_update_service_factory.cc

+++ b/chrome/browser/profiles/gaia_info_update_service_factory.cc

@@ -4,7 +4,7 @@

#include "chrome/browser/profiles/gaia_info_update_service_factory.h"

-#include "chrome/browser/prefs/pref_service_syncable.h"

+#include "chrome/browser/prefs/pref_registry_syncable.h"

#include "chrome/browser/profiles/gaia_info_update_service.h"

#include "chrome/browser/profiles/profile_dependency_manager.h"

#include "chrome/common/pref_names.h"

@@ -36,11 +36,11 @@ ProfileKeyedService* GAIAInfoUpdateServiceFactory::BuildServiceInstanceFor(

}

void GAIAInfoUpdateServiceFactory::RegisterUserPrefs(

- PrefServiceSyncable* prefs) {

+ PrefRegistrySyncable* prefs) {

prefs->RegisterInt64Pref(prefs::kProfileGAIAInfoUpdateTime, 0,

- PrefServiceSyncable::UNSYNCABLE_PREF);

+ PrefRegistrySyncable::UNSYNCABLE_PREF);

prefs->RegisterStringPref(prefs::kProfileGAIAInfoPictureURL, "",

- PrefServiceSyncable::UNSYNCABLE_PREF);

+ PrefRegistrySyncable::UNSYNCABLE_PREF);

}

bool GAIAInfoUpdateServiceFactory::ServiceIsNULLWhileTesting() const {