Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Unified Diff: chrome/browser/prefs/pref_registry.h

Issue 12079097: Introduce PrefRegistrySyncable, simplifying PrefServiceSyncable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add to PrefRegistrySyncable and PrefServiceSyncable to let sync know of pre-registered prefs. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prefs/pref_registry.h
diff --git a/chrome/browser/prefs/pref_registry.h b/chrome/browser/prefs/pref_registry.h
index 327f98733f8549398997ee8765737f80b8e3fc4c..3a2e6ffbaed0055193cfb3b2494d30c01083dab9 100644
--- a/chrome/browser/prefs/pref_registry.h
+++ b/chrome/browser/prefs/pref_registry.h
@@ -52,22 +52,20 @@ class PrefRegistry : public base::RefCounted<PrefRegistry> {
void SetUnregistrationCallback(const UnregistrationCallback& callback);
// Unregisters a preference. This is going away soon.
- virtual void DeprecatedUnregisterPreference(const char* path);
+ void DeprecatedUnregisterPreference(const char* path);
protected:
friend class base::RefCounted<PrefRegistry>;
virtual ~PrefRegistry();
- // TODO(joi): Temporary until we have PrefRegistrySyncable.
- friend class PrefServiceSyncable;
-
// Used by subclasses to register a default value for a preference.
void RegisterPreference(const char* path, base::Value* default_value);
+ scoped_refptr<DefaultPrefStore> defaults_;
+
private:
RegistrationCallback registration_callback_;
UnregistrationCallback unregistration_callback_;
- scoped_refptr<DefaultPrefStore> defaults_;
DISALLOW_COPY_AND_ASSIGN(PrefRegistry);
};

Powered by Google App Engine
This is Rietveld 408576698