Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Unified Diff: chrome/browser/extensions/platform_app_browsertest.cc

Issue 12079097: Introduce PrefRegistrySyncable, simplifying PrefServiceSyncable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add to PrefRegistrySyncable and PrefServiceSyncable to let sync know of pre-registered prefs. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/platform_app_browsertest.cc
diff --git a/chrome/browser/extensions/platform_app_browsertest.cc b/chrome/browser/extensions/platform_app_browsertest.cc
index ab1838773bc6b7d391f922fa247f1da3ab6a87c1..d53839d7c2598d9f1203dda8d762294f6aeb484b 100644
--- a/chrome/browser/extensions/platform_app_browsertest.cc
+++ b/chrome/browser/extensions/platform_app_browsertest.cc
@@ -18,6 +18,7 @@
#include "chrome/browser/extensions/platform_app_browsertest_util.h"
#include "chrome/browser/extensions/platform_app_launcher.h"
#include "chrome/browser/extensions/shell_window_registry.h"
+#include "chrome/browser/prefs/pref_registry_syncable.h"
#include "chrome/browser/prefs/pref_service.h"
#include "chrome/browser/tab_contents/render_view_context_menu.h"
#include "chrome/browser/ui/browser.h"
@@ -873,8 +874,11 @@ IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest,
std::string pref_path("extensions.settings.");
pref_path += extension->id();
pref_path += ".manifest.version";
- extension_prefs->pref_service()->RegisterStringPref(
- pref_path.c_str(), std::string(), PrefServiceSyncable::UNSYNCABLE_PREF);
+ // TODO(joi): Do registrations up front.
+ PrefRegistrySyncable* registry = static_cast<PrefRegistrySyncable*>(
+ extension_prefs->pref_service()->DeprecatedGetPrefRegistry());
+ registry->RegisterStringPref(
+ pref_path.c_str(), std::string(), PrefRegistrySyncable::UNSYNCABLE_PREF);
extension_prefs->pref_service()->Set(pref_path.c_str(), old_version);
}

Powered by Google App Engine
This is Rietveld 408576698