Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5349)

Unified Diff: chrome/browser/extensions/extension_prefs.h

Issue 12079097: Introduce PrefRegistrySyncable, simplifying PrefServiceSyncable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add to PrefRegistrySyncable and PrefServiceSyncable to let sync know of pre-registered prefs. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_prefs.h
diff --git a/chrome/browser/extensions/extension_prefs.h b/chrome/browser/extensions/extension_prefs.h
index c11e7e58b1243c570ad9ac3270403fb8ba5761e3..a1bddfeff1aee09ac9676bfec284b6470a8f4bd5 100644
--- a/chrome/browser/extensions/extension_prefs.h
+++ b/chrome/browser/extensions/extension_prefs.h
@@ -24,7 +24,7 @@
class ExtensionPrefValueMap;
class ExtensionSorting;
class PrefService;
-class PrefServiceSyncable;
+class PrefRegistrySyncable;
namespace extensions {
class ExtensionPrefsUninstallExtension;
@@ -93,7 +93,7 @@ class ExtensionPrefs : public ContentSettingsStore::Observer,
// Creates and initializes an ExtensionPrefs object.
// Does not take ownership of |prefs| and |extension_pref_value_map|.
static scoped_ptr<ExtensionPrefs> Create(
- PrefServiceSyncable* prefs,
+ PrefService* prefs,
const FilePath& root_dir,
ExtensionPrefValueMap* extension_pref_value_map,
bool extensions_disabled);
@@ -101,7 +101,7 @@ class ExtensionPrefs : public ContentSettingsStore::Observer,
// A version of Create which allows injection of a custom base::Time provider.
// Use this as needed for testing.
static scoped_ptr<ExtensionPrefs> Create(
- PrefServiceSyncable* prefs,
+ PrefService* prefs,
const FilePath& root_dir,
ExtensionPrefValueMap* extension_pref_value_map,
bool extensions_disabled,
@@ -479,14 +479,14 @@ class ExtensionPrefs : public ContentSettingsStore::Observer,
// found.
base::Time GetInstallTime(const std::string& extension_id) const;
- static void RegisterUserPrefs(PrefServiceSyncable* prefs);
+ static void RegisterUserPrefs(PrefRegistrySyncable* registry);
ContentSettingsStore* content_settings_store() {
return content_settings_store_.get();
}
// The underlying PrefService.
- PrefServiceSyncable* pref_service() const { return prefs_; }
+ PrefService* pref_service() const { return prefs_; }
// The underlying ExtensionSorting.
ExtensionSorting* extension_sorting() const {
@@ -515,7 +515,7 @@ class ExtensionPrefs : public ContentSettingsStore::Observer,
friend class ExtensionPrefsUninstallExtension; // Unit test.
// See the Create methods.
- ExtensionPrefs(PrefServiceSyncable* prefs,
+ ExtensionPrefs(PrefService* prefs,
const FilePath& root_dir,
ExtensionPrefValueMap* extension_pref_value_map,
scoped_ptr<TimeProvider> time_provider);
@@ -635,7 +635,7 @@ class ExtensionPrefs : public ContentSettingsStore::Observer,
DictionaryValue* extension_dict);
// The pref service specific to this set of extension prefs. Owned by profile.
- PrefServiceSyncable* prefs_;
+ PrefService* prefs_;
// Base extensions install directory.
FilePath install_directory_;

Powered by Google App Engine
This is Rietveld 408576698