Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3537)

Unified Diff: chrome/browser/download/chrome_download_manager_delegate.cc

Issue 12079097: Introduce PrefRegistrySyncable, simplifying PrefServiceSyncable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add to PrefRegistrySyncable and PrefServiceSyncable to let sync know of pre-registered prefs. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/chrome_download_manager_delegate.cc
diff --git a/chrome/browser/download/chrome_download_manager_delegate.cc b/chrome/browser/download/chrome_download_manager_delegate.cc
index 6e0b31a0eb6562cefc198e2bf415dc44113f05c6..585ec71d3960673bd136e5d1898e072d1a7375c2 100644
--- a/chrome/browser/download/chrome_download_manager_delegate.cc
+++ b/chrome/browser/download/chrome_download_manager_delegate.cc
@@ -34,6 +34,7 @@
#include "chrome/browser/history/history_service_factory.h"
#include "chrome/browser/intents/web_intents_util.h"
#include "chrome/browser/platform_util.h"
+#include "chrome/browser/prefs/pref_registry_syncable.h"
#include "chrome/browser/prefs/pref_service.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/safe_browsing/safe_browsing_service.h"
@@ -490,7 +491,7 @@ void ChromeDownloadManagerDelegate::GetSaveDir(BrowserContext* browser_context,
FilePath* download_save_dir,
bool* skip_dir_check) {
Profile* profile = Profile::FromBrowserContext(browser_context);
- PrefServiceSyncable* prefs = profile->GetPrefs();
+ PrefService* prefs = profile->GetPrefs();
// Check whether the preference has the preferred directory for saving file.
// If not, initialize it with default directory.
@@ -498,9 +499,13 @@ void ChromeDownloadManagerDelegate::GetSaveDir(BrowserContext* browser_context,
DCHECK(prefs->FindPreference(prefs::kDownloadDefaultDirectory));
FilePath default_save_path = prefs->GetFilePath(
prefs::kDownloadDefaultDirectory);
- prefs->RegisterFilePathPref(prefs::kSaveFileDefaultDirectory,
- default_save_path,
- PrefServiceSyncable::UNSYNCABLE_PREF);
+
+ // TODO(joi): All registration should be done up front.
+ scoped_refptr<PrefRegistrySyncable> registry(
+ static_cast<PrefRegistrySyncable*>(prefs->DeprecatedGetPrefRegistry()));
+ registry->RegisterFilePathPref(prefs::kSaveFileDefaultDirectory,
+ default_save_path,
+ PrefRegistrySyncable::UNSYNCABLE_PREF);
}
// Get the directory from preference.

Powered by Google App Engine
This is Rietveld 408576698