chrome/browser/chromeos/proxy_config_service_impl.cc - Issue 12079097: Introduce PrefRegistrySyncable, simplifying PrefServiceSyncable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/proxy_config_service_impl.cc

Issue 12079097: Introduce PrefRegistrySyncable, simplifying PrefServiceSyncable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add to PrefRegistrySyncable and PrefServiceSyncable to let sync know of pre-registered prefs. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/proxy_config_service_impl.cc

diff --git a/chrome/browser/chromeos/proxy_config_service_impl.cc b/chrome/browser/chromeos/proxy_config_service_impl.cc

index cb375dd5b9ef826860f69c672cdddfca7f4702c8..528d22d80634e425dc2cfeedfda80e62bb107e41 100644

--- a/chrome/browser/chromeos/proxy_config_service_impl.cc

+++ b/chrome/browser/chromeos/proxy_config_service_impl.cc

@@ -16,6 +16,7 @@

#include "chrome/browser/chromeos/settings/cros_settings_names.h"

#include "chrome/browser/policy/proto/chrome_device_policy.pb.h"

#include "chrome/browser/prefs/pref_registry_simple.h"

+#include "chrome/browser/prefs/pref_registry_syncable.h"

#include "chrome/browser/prefs/pref_service.h"

#include "chrome/browser/prefs/proxy_config_dictionary.h"

#include "chrome/browser/prefs/proxy_prefs.h"

@@ -588,11 +589,10 @@ void ProxyConfigServiceImpl::RegisterPrefs(PrefRegistrySimple* registry) {

}

// static

-void ProxyConfigServiceImpl::RegisterUserPrefs(

- PrefServiceSyncable* pref_service) {

- pref_service->RegisterBooleanPref(prefs::kUseSharedProxies,

- true,

- PrefServiceSyncable::UNSYNCABLE_PREF);

+void ProxyConfigServiceImpl::RegisterUserPrefs(PrefRegistrySyncable* registry) {

+ registry->RegisterBooleanPref(prefs::kUseSharedProxies,

+ true,

+ PrefRegistrySyncable::UNSYNCABLE_PREF);

}

//------------------ ProxyConfigServiceImpl: private methods -------------------