Introduce PrefRegistrySyncable, simplifying PrefServiceSyncable.

chrome/browser/printing/print_dialog_cloud.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/printing/print_dialog_cloud.h"
 #include "chrome/browser/printing/print_dialog_cloud_internal.h"
 
 #include "base/base64.h"
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/json/json_reader.h"
 #include "base/utf_string_conversions.h"
 #include "base/values.h"
 #include "chrome/browser/devtools/devtools_window.h"
 #include "chrome/browser/lifetime/application_lifetime.h"
+#include "chrome/browser/prefs/pref_registry_syncable.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/printing/cloud_print/cloud_print_url.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/ui/browser_dialogs.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/print_messages.h"
 #include "chrome/common/url_constants.h"
 #include "content/public/browser/browser_thread.h"
@@ skipping 496 matching lines @@
                                       int* width,
                                       int* height) {
   const int kDefaultWidth = 912;
   const int kDefaultHeight = 633;
   if (!browser_context) {
     *width = kDefaultWidth;
     *height = kDefaultHeight;
     return;
   }
 
-  Profile* profile = Profile::FromBrowserContext(browser_context);
-  if (!profile->GetPrefs()->FindPreference(prefs::kCloudPrintDialogWidth)) {
-    profile->GetPrefs()->RegisterIntegerPref(
+  // TODO(joi): Do registration up front.
+  PrefService* prefs = Profile::FromBrowserContext(browser_context)->GetPrefs();
+  scoped_refptr<PrefRegistrySyncable> registry(
+      static_cast<PrefRegistrySyncable*>(prefs->DeprecatedGetPrefRegistry()));
+  if (!prefs->FindPreference(prefs::kCloudPrintDialogWidth)) {
+    registry->RegisterIntegerPref(
         prefs::kCloudPrintDialogWidth,
         kDefaultWidth,
-        PrefServiceSyncable::UNSYNCABLE_PREF);
+        PrefRegistrySyncable::UNSYNCABLE_PREF);
   }
-  if (!profile->GetPrefs()->FindPreference(prefs::kCloudPrintDialogHeight)) {
-    profile->GetPrefs()->RegisterIntegerPref(
+  if (!prefs->FindPreference(prefs::kCloudPrintDialogHeight)) {
+    registry->RegisterIntegerPref(
         prefs::kCloudPrintDialogHeight,
         kDefaultHeight,
-        PrefServiceSyncable::UNSYNCABLE_PREF);
+        PrefRegistrySyncable::UNSYNCABLE_PREF);
   }
 
-  *width = profile->GetPrefs()->GetInteger(prefs::kCloudPrintDialogWidth);
-  *height = profile->GetPrefs()->GetInteger(prefs::kCloudPrintDialogHeight);
+  *width = prefs->GetInteger(prefs::kCloudPrintDialogWidth);
+  *height = prefs->GetInteger(prefs::kCloudPrintDialogHeight);
 }
 
 void CloudPrintWebDialogDelegate::Init(content::BrowserContext* browser_context,
                                        const std::string& json_arguments) {
   // This information is needed to show the dialog HTML content.
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
   params_.url = GURL(chrome::kChromeUICloudPrintResourcesURL);
   GetDialogWidthAndHeightFromPrefs(browser_context,
                                    &params_.width,
@@ skipping 275 matching lines @@
           print_job_print_ticket,
           file_type,
           delete_on_close);
       return true;
     }
   }
   return false;
 }
 
 }  // end namespace