Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1638)

Side by Side Diff: chrome/browser/password_manager/password_manager.cc

Issue 12079097: Introduce PrefRegistrySyncable, simplifying PrefServiceSyncable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge to head again; base::File changes conflicted. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/password_manager/password_manager.h" 5 #include "chrome/browser/password_manager/password_manager.h"
6 6
7 #include "base/metrics/histogram.h" 7 #include "base/metrics/histogram.h"
8 #include "base/string_util.h"
8 #include "base/threading/platform_thread.h" 9 #include "base/threading/platform_thread.h"
9 #include "base/string_util.h"
10 #include "base/utf_string_conversions.h" 10 #include "base/utf_string_conversions.h"
11 #include "chrome/browser/password_manager/password_form_manager.h" 11 #include "chrome/browser/password_manager/password_form_manager.h"
12 #include "chrome/browser/password_manager/password_manager_delegate.h" 12 #include "chrome/browser/password_manager/password_manager_delegate.h"
13 #include "chrome/browser/prefs/pref_registry_syncable.h"
13 #include "chrome/browser/prefs/pref_service.h" 14 #include "chrome/browser/prefs/pref_service.h"
14 #include "chrome/browser/profiles/profile.h" 15 #include "chrome/browser/profiles/profile.h"
15 #include "chrome/common/autofill_messages.h" 16 #include "chrome/common/autofill_messages.h"
16 #include "chrome/common/pref_names.h" 17 #include "chrome/common/pref_names.h"
17 #include "content/public/browser/user_metrics.h" 18 #include "content/public/browser/user_metrics.h"
18 #include "content/public/browser/web_contents.h" 19 #include "content/public/browser/web_contents.h"
19 #include "content/public/common/frame_navigate_params.h" 20 #include "content/public/common/frame_navigate_params.h"
20 #include "grit/generated_resources.h" 21 #include "grit/generated_resources.h"
21 22
22 using content::UserMetricsAction; 23 using content::UserMetricsAction;
(...skipping 27 matching lines...) Expand all
50 // a boolean histogram. 51 // a boolean histogram.
51 if (password_manager_enabled) 52 if (password_manager_enabled)
52 content::RecordAction(UserMetricsAction("PasswordManager_Enabled")); 53 content::RecordAction(UserMetricsAction("PasswordManager_Enabled"));
53 else 54 else
54 content::RecordAction(UserMetricsAction("PasswordManager_Disabled")); 55 content::RecordAction(UserMetricsAction("PasswordManager_Disabled"));
55 } 56 }
56 57
57 } // anonymous namespace 58 } // anonymous namespace
58 59
59 // static 60 // static
60 void PasswordManager::RegisterUserPrefs(PrefServiceSyncable* prefs) { 61 void PasswordManager::RegisterUserPrefs(PrefRegistrySyncable* registry) {
61 prefs->RegisterBooleanPref(prefs::kPasswordManagerEnabled, 62 registry->RegisterBooleanPref(prefs::kPasswordManagerEnabled,
62 true, 63 true,
63 PrefServiceSyncable::SYNCABLE_PREF); 64 PrefRegistrySyncable::SYNCABLE_PREF);
64 prefs->RegisterBooleanPref(prefs::kPasswordManagerAllowShowPasswords, 65 registry->RegisterBooleanPref(prefs::kPasswordManagerAllowShowPasswords,
65 true, 66 true,
66 PrefServiceSyncable::UNSYNCABLE_PREF); 67 PrefRegistrySyncable::UNSYNCABLE_PREF);
67 } 68 }
68 69
69 // static 70 // static
70 void PasswordManager::CreateForWebContentsAndDelegate( 71 void PasswordManager::CreateForWebContentsAndDelegate(
71 content::WebContents* contents, 72 content::WebContents* contents,
72 PasswordManagerDelegate* delegate) { 73 PasswordManagerDelegate* delegate) {
73 if (FromWebContents(contents)) { 74 if (FromWebContents(contents)) {
74 DCHECK_EQ(delegate, FromWebContents(contents)->delegate_); 75 DCHECK_EQ(delegate, FromWebContents(contents)->delegate_);
75 return; 76 return;
76 } 77 }
(...skipping 236 matching lines...) Expand 10 before | Expand all | Expand 10 after
313 delegate_->FillPasswordForm(fill_data); 314 delegate_->FillPasswordForm(fill_data);
314 return; 315 return;
315 } 316 }
316 default: 317 default:
317 if (observer_) { 318 if (observer_) {
318 observer_->OnAutofillDataAvailable(preferred_match.username_value, 319 observer_->OnAutofillDataAvailable(preferred_match.username_value,
319 preferred_match.password_value); 320 preferred_match.password_value);
320 } 321 }
321 } 322 }
322 } 323 }
OLDNEW
« no previous file with comments | « chrome/browser/password_manager/password_manager.h ('k') | chrome/browser/password_manager/password_store_factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698