Introduce PrefRegistrySyncable, simplifying PrefServiceSyncable.

ui/shell_dialogs/select_file_dialog.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_SHELL_DIALOGS_SELECT_FILE_DIALOG_H_
 #define UI_SHELL_DIALOGS_SELECT_FILE_DIALOG_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 88 matching lines @@
   struct SHELL_DIALOGS_EXPORT FileTypeInfo {
     FileTypeInfo();
     ~FileTypeInfo();
 
     // A list of allowed extensions. For example, it might be
     //
     //   { { "htm", "html" }, { "txt" } }
     //
     // Only pass more than one extension in the inner vector if the extensions
     // are equivalent. Do NOT include leading periods.
-    std::vector<std::vector<FilePath::StringType> > extensions;
+    std::vector<std::vector<base::FilePath::StringType> > extensions;

[Mattias Nissler (ping if slow), 2013/02/06 17:53:33]

unrelated changes?

[Jói, 2013/02/07 14:52:32]

Yes, as in pref_member.h. Removed.

 
     // Overrides the system descriptions of the specified extensions. Entries
     // correspond to |extensions|; if left blank the system descriptions will
     // be used.
     std::vector<string16> extension_description_overrides;
 
     // Specifies whether there will be a filter added for all files (i.e. *.*).
     bool include_all_files;
 
     // Specifies whether the caller can support files/folders that are on
@@ skipping 26 matching lines @@
   //   modeless dialog.
   // |params| is data from the calling context which will be passed through to
   //   the listener. Can be NULL.
   // NOTE: only one instance of any shell dialog can be shown per owning_window
   //       at a time (for obvious reasons).
   void SelectFile(Type type,
                   const string16& title,
                   const FilePath& default_path,
                   const FileTypeInfo* file_types,
                   int file_type_index,
-                  const FilePath::StringType& default_extension,
+                  const base::FilePath::StringType& default_extension,
                   gfx::NativeWindow owning_window,
                   void* params);
   bool HasMultipleFileTypeChoices();
 
   // Sets the global ShellDialogsDelegate. Defaults to NULL.
   static void SetShellDialogsDelegate(ShellDialogsDelegate* delegate);
 
  protected:
   friend class base::RefCountedThreadSafe<SelectFileDialog>;
   explicit SelectFileDialog(Listener* listener,
                             ui::SelectFilePolicy* policy);
   virtual ~SelectFileDialog();
 
   // Displays the actual file-selection dialog.
   // This is overridden in the platform-specific descendants of FileSelectDialog
   // and gets called from SelectFile after testing the
   // AllowFileSelectionDialogs-Policy.
-  virtual void SelectFileImpl(Type type,
-                              const string16& title,
-                              const FilePath& default_path,
-                              const FileTypeInfo* file_types,
-                              int file_type_index,
-                              const FilePath::StringType& default_extension,
-                              gfx::NativeWindow owning_window,
-                              void* params) = 0;
+  virtual void SelectFileImpl(
+      Type type,
+      const string16& title,
+      const FilePath& default_path,
+      const FileTypeInfo* file_types,
+      int file_type_index,
+      const base::FilePath::StringType& default_extension,
+      gfx::NativeWindow owning_window,
+      void* params) = 0;
 
   // Returns the global ShellDialogsDelegate instance if any.
   ShellDialogsDelegate* GetShellDialogsDelegate();
 
   // The listener to be notified of selection completion.
   Listener* listener_;
 
  private:
   // Tests if the file selection dialog can be displayed by
   // testing if the AllowFileSelectionDialogs-Policy is
   // either unset or set to true.
   bool CanOpenSelectFileDialog();
 
   // Informs the |listener_| that the file selection dialog was canceled. Moved
   // to a function for being able to post it to the message loop.
   void CancelFileSelection(void* params);
 
   // Returns true if the dialog has multiple file type choices.
   virtual bool HasMultipleFileTypeChoicesImpl() = 0;
 
   scoped_ptr<ui::SelectFilePolicy> select_file_policy_;
 
   DISALLOW_COPY_AND_ASSIGN(SelectFileDialog);
 };
 
 }  // namespace ui
 
 #endif  // UI_SHELL_DIALOGS_SELECT_FILE_DIALOG_H_