chrome/browser/extensions/shell_window_geometry_cache_unittest.cc - Issue 12079097: Introduce PrefRegistrySyncable, simplifying PrefServiceSyncable.

Side by Side Diff: chrome/browser/extensions/shell_window_geometry_cache_unittest.cc

Issue 12079097: Introduce PrefRegistrySyncable, simplifying PrefServiceSyncable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add to PrefRegistrySyncable and PrefServiceSyncable to let sync know of pre-registered prefs. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/extensions/menu_manager_unittest.cc ('K') | « chrome/browser/extensions/platform_app_browsertest.cc ('k') | chrome/browser/extensions/test_extension_prefs.cc » ('j') | chrome/browser/extensions/test_extension_prefs.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/memory/scoped_ptr.h"	5 #include "base/memory/scoped_ptr.h"

6 #include "base/string_number_conversions.h"	6 #include "base/string_number_conversions.h"

7 #include "chrome/browser/extensions/extension_prefs.h"	7 #include "chrome/browser/extensions/extension_prefs.h"

8 #include "chrome/browser/extensions/shell_window_geometry_cache.h"	8 #include "chrome/browser/extensions/shell_window_geometry_cache.h"

9 #include "chrome/browser/extensions/test_extension_prefs.h"	9 #include "chrome/browser/extensions/test_extension_prefs.h"

10 #include "chrome/browser/prefs/mock_pref_change_callback.h"	10 #include "chrome/browser/prefs/mock_pref_change_callback.h"

	11 #include "chrome/browser/prefs/pref_service_syncable.h"

	12 #include "chrome/browser/prefs/pref_service_syncable.h"
	Mattias Nissler (ping if slow) 2013/02/06 17:53:33 one is enough. or did you mean to include pref_reg one is enough. or did you mean to include pref_registry_syncable.h? Jói 2013/02/07 14:52:32 Done. Show quoted text On 2013/02/06 17:53:33, Mattias Nissler wrote: > one is enough. or did you mean to include pref_registry_syncable.h? Done.
11 #include "chrome/test/base/testing_profile.h"	13 #include "chrome/test/base/testing_profile.h"

12 #include "content/public/test/test_browser_thread.h"	14 #include "content/public/test/test_browser_thread.h"

13 #include "content/public/test/test_utils.h"	15 #include "content/public/test/test_utils.h"

14 #include "testing/gtest/include/gtest/gtest.h"	16 #include "testing/gtest/include/gtest/gtest.h"

15	17

16 namespace {	18 namespace {

17 static const char kWindowId[] = "windowid";	19 static const char kWindowId[] = "windowid";

18 static const char kWindowId2[] = "windowid2";	20 static const char kWindowId2[] = "windowid2";

19	21

20 const char kWindowGeometryKey[] = "window_geometry";	22 const char kWindowGeometryKey[] = "window_geometry";

(...skipping 196 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
217 // The first added window should no longer have cached geometry.	219 // The first added window should no longer have cached geometry.

218 EXPECT_FALSE(cache_->GetGeometry(extension_id, "window_0", &bounds));	220 EXPECT_FALSE(cache_->GetGeometry(extension_id, "window_0", &bounds));

219 // All other windows should still exist.	221 // All other windows should still exist.

220 for (size_t i = 1; i < ShellWindowGeometryCache::kMaxCachedWindows + 1; ++i) {	222 for (size_t i = 1; i < ShellWindowGeometryCache::kMaxCachedWindows + 1; ++i) {

221 std::string window_id = "window_" + base::IntToString(i);	223 std::string window_id = "window_" + base::IntToString(i);

222 EXPECT_TRUE(cache_->GetGeometry(extension_id, window_id, &bounds));	224 EXPECT_TRUE(cache_->GetGeometry(extension_id, window_id, &bounds));

223 }	225 }

224 }	226 }

225	227

226 } // namespace extensions	228 } // namespace extensions

OLD	NEW