Introduce PrefRegistrySyncable, simplifying PrefServiceSyncable.

chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/custom_handlers/protocol_handler_registry.h"
 
 #include <set>
 
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop.h"
 #include "base/synchronization/waitable_event.h"
 #include "base/utf_string_conversions.h"
+#include "chrome/browser/prefs/pref_registry_syncable.h"
+#include "chrome/browser/prefs/pref_service_syncable.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/custom_handlers/protocol_handler.h"
 #include "chrome/test/base/testing_browser_process.h"
 #include "chrome/test/base/testing_pref_service.h"
 #include "chrome/test/base/testing_profile.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
 #include "content/public/browser/notification_source.h"
 #include "content/public/test/test_browser_thread.h"
 #include "content/public/test/test_renderer_host.h"
@@ skipping 298 matching lines @@
   : ui_thread_(BrowserThread::UI, &loop_),
     file_thread_(BrowserThread::FILE, &loop_),
     io_thread_(BrowserThread::IO, &loop_),
     test_protocol_handler_(CreateProtocolHandler("test", "test")) {}
 
   FakeDelegate* delegate() const { return delegate_; }
   ProtocolHandlerRegistry* registry() { return registry_.get(); }
   TestingProfile* profile() const { return profile_.get(); }
   // TODO(joi): Check if this can be removed, as well as the call to
   // SetPrefService in SetUp.
-  PrefServiceSyncable* pref_service() const { return profile_->GetPrefs(); }
+  PrefServiceSyncable* pref_service() const {
+    return PrefServiceSyncable::FromProfile(profile_.get());
+  }
   const ProtocolHandler& test_protocol_handler() const {
     return test_protocol_handler_;
   }
 
   ProtocolHandler CreateProtocolHandler(const std::string& protocol,
                                         const GURL& url,
                                         const std::string& title) {
     return ProtocolHandler::CreateProtocolHandler(protocol, url,
         UTF8ToUTF16(title));
   }
@@ skipping 25 matching lines @@
 
   virtual void SetUp() {
     profile_.reset(new TestingProfile());
     profile_->SetPrefService(new TestingPrefServiceSyncable());
     SetUpRegistry(true);
     test_protocol_handler_ =
         CreateProtocolHandler("test", GURL("http://test.com/%s"), "Test");
 
     // TODO(joi): If pref_service() and the SetPrefService above go,
     // then this could go.
-    ProtocolHandlerRegistry::RegisterUserPrefs(pref_service());
+    ProtocolHandlerRegistry::RegisterUserPrefs(
+        static_cast<PrefRegistrySyncable*>(
+            pref_service()->DeprecatedGetPrefRegistry()));

[Mattias Nissler (ping if slow), 2013/02/06 17:53:33]

I guess you can just drop this and line 374 and remove the pref_service() getter
and things will still work?

[Jói, 2013/02/07 14:52:32]

I did the same as Joe Thomas contributed in
https://codereview.chromium.org/12211026/diff/1/chrome/browser/custom_handler...
(pending commit), i.e. remove the code and add a CHECK(profile_->GetPrefs()).

[Mattias Nissler (ping if slow), 2013/02/08 11:26:56]

Good solution, thanks!

   }
 
   virtual void TearDown() {
     TeadDownRegistry();
   }
 
   TestMessageLoop loop_;
 
  private:
   content::TestBrowserThread ui_thread_;
@@ skipping 550 matching lines @@
 
 TEST_F(ProtocolHandlerRegistryTest, MAYBE_TestInstallDefaultHandler) {
   RecreateRegistry(false);
   registry()->AddPredefinedHandler(CreateProtocolHandler(
       "test", GURL("http://test.com/%s"), "Test"));
   registry()->InitProtocolSettings();
   std::vector<std::string> protocols;
   registry()->GetRegisteredProtocols(&protocols);
   ASSERT_EQ(static_cast<size_t>(1), protocols.size());
 }