Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Side by Side Diff: chrome/browser/bookmarks/bookmark_prompt_prefs.cc

Issue 12079097: Introduce PrefRegistrySyncable, simplifying PrefServiceSyncable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: One more merge to head. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/bookmarks/bookmark_prompt_prefs.h" 5 #include "chrome/browser/bookmarks/bookmark_prompt_prefs.h"
6 6
7 #include "chrome/browser/prefs/pref_service_syncable.h" 7 #include "chrome/browser/prefs/pref_registry_syncable.h"
8 #include "chrome/browser/prefs/pref_service.h"
tfarina 2013/02/09 17:06:24 why you need this?
8 #include "chrome/common/pref_names.h" 9 #include "chrome/common/pref_names.h"
9 10
10 BookmarkPromptPrefs::BookmarkPromptPrefs(PrefServiceBase* user_prefs) 11 BookmarkPromptPrefs::BookmarkPromptPrefs(PrefServiceBase* user_prefs)
11 : prefs_(user_prefs) { 12 : prefs_(user_prefs) {
12 } 13 }
13 14
14 BookmarkPromptPrefs::~BookmarkPromptPrefs() { 15 BookmarkPromptPrefs::~BookmarkPromptPrefs() {
15 } 16 }
16 17
17 void BookmarkPromptPrefs::DisableBookmarkPrompt() { 18 void BookmarkPromptPrefs::DisableBookmarkPrompt() {
18 prefs_->SetBoolean(prefs::kBookmarkPromptEnabled, false); 19 prefs_->SetBoolean(prefs::kBookmarkPromptEnabled, false);
19 } 20 }
20 21
21 int BookmarkPromptPrefs::GetPromptImpressionCount() const { 22 int BookmarkPromptPrefs::GetPromptImpressionCount() const {
22 return prefs_->GetInteger(prefs::kBookmarkPromptImpressionCount); 23 return prefs_->GetInteger(prefs::kBookmarkPromptImpressionCount);
23 } 24 }
24 25
25 void BookmarkPromptPrefs::IncrementPromptImpressionCount() { 26 void BookmarkPromptPrefs::IncrementPromptImpressionCount() {
26 prefs_->SetInteger(prefs::kBookmarkPromptImpressionCount, 27 prefs_->SetInteger(prefs::kBookmarkPromptImpressionCount,
27 GetPromptImpressionCount() + 1); 28 GetPromptImpressionCount() + 1);
28 } 29 }
29 30
30 bool BookmarkPromptPrefs::IsBookmarkPromptEnabled() const { 31 bool BookmarkPromptPrefs::IsBookmarkPromptEnabled() const {
31 return prefs_->GetBoolean(prefs::kBookmarkPromptEnabled); 32 return prefs_->GetBoolean(prefs::kBookmarkPromptEnabled);
32 } 33 }
33 34
34 // static 35 // static
35 void BookmarkPromptPrefs::RegisterUserPrefs(PrefServiceSyncable* user_prefs) { 36 void BookmarkPromptPrefs::RegisterUserPrefs(PrefRegistrySyncable* registry) {
36 // We always register preferences without checking FieldTrial, because 37 // We always register preferences without checking FieldTrial, because
37 // we may not receive field trial list from the server yet. 38 // we may not receive field trial list from the server yet.
38 user_prefs->RegisterBooleanPref(prefs::kBookmarkPromptEnabled, true, 39 registry->RegisterBooleanPref(prefs::kBookmarkPromptEnabled, true,
39 PrefServiceSyncable::UNSYNCABLE_PREF); 40 PrefRegistrySyncable::UNSYNCABLE_PREF);
40 user_prefs->RegisterIntegerPref(prefs::kBookmarkPromptImpressionCount, 0, 41 registry->RegisterIntegerPref(prefs::kBookmarkPromptImpressionCount, 0,
41 PrefServiceSyncable::UNSYNCABLE_PREF); 42 PrefRegistrySyncable::UNSYNCABLE_PREF);
42 } 43 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698