Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Issue 12079070: Rename tab_backend to inspector_backend. (Closed)

Created:
7 years, 10 months ago by achuithb
Modified:
7 years, 10 months ago
Reviewers:
dtu, nduca
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Visibility:
Public.

Description

Rename tab_backend to inspector_backend. BUG=None TEST=run_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179977

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -326 lines) Patch
A + tools/telemetry/telemetry/inspector_backend.py View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/inspector_console.py View 1 2 chunks +4 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/inspector_page.py View 1 5 chunks +8 lines, -8 lines 0 comments Download
M tools/telemetry/telemetry/inspector_runtime.py View 1 2 chunks +4 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/inspector_timeline.py View 1 3 chunks +5 lines, -5 lines 0 comments Download
D tools/telemetry/telemetry/tab_backend.py View 1 1 chunk +0 lines, -298 lines 0 comments Download
M tools/telemetry/telemetry/tab_list_backend.py View 1 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
achuithb
Dave: Renamed as suggested in https://codereview.chromium.org/11882033/
7 years, 10 months ago (2013-01-30 09:55:31 UTC) #1
dtu
lgtm
7 years, 10 months ago (2013-01-31 01:38:06 UTC) #2
achuithb
On 2013/01/31 01:38:06, Dave Tu wrote: > lgtm Thank you!
7 years, 10 months ago (2013-01-31 02:02:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/12079070/1
7 years, 10 months ago (2013-01-31 02:10:37 UTC) #4
commit-bot: I haz the power
Failed to apply patch for tools/telemetry/telemetry/inspector_backend.py: While running patch -p0 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 10 months ago (2013-01-31 02:10:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/12079070/1008
7 years, 10 months ago (2013-01-31 02:49:17 UTC) #6
commit-bot: I haz the power
7 years, 10 months ago (2013-01-31 02:49:19 UTC) #7
Failed to apply patch for tools/telemetry/telemetry/inspector_backend.py:
While running patch -p0 --forward --force --no-backup-if-mismatch;
  patching file tools/telemetry/telemetry/inspector_backend.py
  Hunk #1 FAILED at 18.
  Hunk #2 FAILED at 278.
  2 out of 2 hunks FAILED -- saving rejects to file
tools/telemetry/telemetry/inspector_backend.py.rej

Patch:   N   tools/telemetry/telemetry/inspector_backend.py
Index: tools/telemetry/telemetry/inspector_backend.py
===================================================================
--- tools/telemetry/telemetry/inspector_backend.py	(revision 179449)
+++ tools/telemetry/telemetry/inspector_backend.py	(working copy)
@@ -18,7 +18,7 @@
 class InspectorException(Exception):
   pass
 
-class TabBackend(object):
+class InspectorBackend(object):
   def __init__(self, browser, browser_backend, debugger_url):
     assert debugger_url
     self._browser = browser
@@ -278,14 +278,14 @@
       domain_name, notification_handler, will_close_handler):
     """Registers a given domain for handling notification methods.
 
-    For example, given tab_backend:
+    For example, given inspector_backend:
        def OnConsoleNotification(msg):
           if msg['method'] == 'Console.messageAdded':
              print msg['params']['message']
           return
        def OnConsoleClose(self):
           pass
-       tab_backend.RegisterDomain('Console',
+       inspector_backend.RegisterDomain('Console',
                                         OnConsoleNotification, OnConsoleClose)
        """
     assert domain_name not in self._domain_handlers

Powered by Google App Engine
This is Rietveld 408576698