Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 12079044: Fix enable state of Pepper Flash. (Closed)

Created:
7 years, 10 months ago by yzshen1
Modified:
7 years, 10 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Fix enable state of Pepper Flash. Component-updated and bundled Pepper Flash share the same enable state. When reading from the Preferences file, the previous code ignored the enable state if it was associated with the component-updated path. That was wrong because if the component-updated Flash was newer, the enable state would be recorded with that path. The outcome was that everytime users restarted the browser, Pepper Flash was enabled, even if they disabled it before. TBR=bauerb@chromium.org BUG=150596 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180288

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M chrome/browser/plugins/plugin_prefs.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/plugins/plugin_prefs.cc View 2 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
yzshen1
Hi, Bernhard. Would you please take a look at this? Thanks!
7 years, 10 months ago (2013-01-29 18:37:46 UTC) #1
viettrungluu
Rubberstamp LGTM. (It looks good insofar as I understand it, which isn't very well.)
7 years, 10 months ago (2013-02-02 06:46:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/12079044/1
7 years, 10 months ago (2013-02-02 06:51:27 UTC) #3
Bernhard Bauer
lgtm
7 years, 10 months ago (2013-02-02 07:21:38 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=106912
7 years, 10 months ago (2013-02-02 09:01:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/12079044/1
7 years, 10 months ago (2013-02-02 09:48:43 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=106955
7 years, 10 months ago (2013-02-02 13:09:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/12079044/1
7 years, 10 months ago (2013-02-02 16:11:59 UTC) #8
commit-bot: I haz the power
7 years, 10 months ago (2013-02-02 19:32:50 UTC) #9
Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698