Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 12079037: Add PRESUBMIT.py to tools/sharding_supervisor/ (Closed)

Created:
7 years, 10 months ago by M-A Ruel
Modified:
7 years, 10 months ago
Reviewers:
csharp
CC:
chromium-reviews, Mike Stip (use stip instead)
Visibility:
Public.

Description

Add PRESUBMIT.py to tools/sharding_supervisor/ While it's being deleted relatively soon, it's easier to have checks in. R=csharp@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179444

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -24 lines) Patch
A + tools/sharding_supervisor/PRESUBMIT.py View 2 chunks +4 lines, -7 lines 0 comments Download
M tools/sharding_supervisor/sharding_supervisor.py View 6 chunks +8 lines, -10 lines 2 comments Download
M tools/sharding_supervisor/stdio_buffer.py View 2 chunks +5 lines, -7 lines 1 comment Download

Messages

Total messages: 9 (0 generated)
M-A Ruel
7 years, 10 months ago (2013-01-29 01:31:40 UTC) #1
csharp
https://codereview.chromium.org/12079037/diff/1/tools/sharding_supervisor/sharding_supervisor.py File tools/sharding_supervisor/sharding_supervisor.py (right): https://codereview.chromium.org/12079037/diff/1/tools/sharding_supervisor/sharding_supervisor.py#newcode258 tools/sharding_supervisor/sharding_supervisor.py:258: buf = StdioBuffer(shard) Why change buffer to buf? https://codereview.chromium.org/12079037/diff/1/tools/sharding_supervisor/stdio_buffer.py ...
7 years, 10 months ago (2013-01-29 01:34:18 UTC) #2
M-A Ruel
https://codereview.chromium.org/12079037/diff/1/tools/sharding_supervisor/sharding_supervisor.py File tools/sharding_supervisor/sharding_supervisor.py (right): https://codereview.chromium.org/12079037/diff/1/tools/sharding_supervisor/sharding_supervisor.py#newcode258 tools/sharding_supervisor/sharding_supervisor.py:258: buf = StdioBuffer(shard) On 2013/01/29 01:34:18, csharp wrote: > ...
7 years, 10 months ago (2013-01-29 01:36:40 UTC) #3
csharp
Ah, LGTM
7 years, 10 months ago (2013-01-29 01:37:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/12079037/1
7 years, 10 months ago (2013-01-29 01:41:09 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 10 months ago (2013-01-29 02:15:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/12079037/1
7 years, 10 months ago (2013-01-29 15:23:59 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 10 months ago (2013-01-29 16:00:05 UTC) #8
commit-bot: I haz the power
7 years, 10 months ago (2013-01-29 21:25:13 UTC) #9

Powered by Google App Engine
This is Rietveld 408576698