tools/gn/header_checker.cc - Issue 1207903002: Windows precompiled header support in GN

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/header_checker.cc

Issue 1207903002: Windows precompiled header support in GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Scott's grammar nits Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/header_checker.cc

diff --git a/tools/gn/header_checker.cc b/tools/gn/header_checker.cc

index d05524381a5e583fd663c303aff4d62d76df6f39..1141e6efd6ac73eca9e90383bc53eb38229b12d0 100644

--- a/tools/gn/header_checker.cc

+++ b/tools/gn/header_checker.cc

@@ -158,7 +158,7 @@ void HeaderChecker::RunCheckOverFiles(const FileMap& files, bool force_check) {

for (const auto& file : files) {

// Only check C-like source files (RC files also have includes).

SourceFileType type = GetSourceFileType(file.first);

- if (type != SOURCE_CC && type != SOURCE_H && type != SOURCE_C &&

+ if (type != SOURCE_CPP && type != SOURCE_H && type != SOURCE_C &&

type != SOURCE_M && type != SOURCE_MM && type != SOURCE_RC)

continue;

« no previous file with comments | « tools/gn/function_toolchain.cc ('k') | tools/gn/ninja_binary_target_writer.h » ('j') | no next file with comments »