Minimize black screen during the boot with multi displays

chromeos/display/output_configurator.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/display/output_configurator.h"
 
 #include <cmath>
 
 #include <X11/Xatom.h>
 #include <X11/Xlib.h>
@@ skipping 516 matching lines @@
     : is_running_on_chrome_os_(base::chromeos::IsRunningOnChromeOS()),
       is_panel_fitting_enabled_(false),
       connected_output_count_(0),
       xrandr_event_base_(0),
       output_state_(STATE_INVALID),
       mirror_mode_will_preserve_aspect_(false),
       mirror_mode_preserved_aspect_(false),
       last_enter_state_time_() {
 }
 
-void OutputConfigurator::Init(bool is_panel_fitting_enabled) {
+OutputConfigurator::~OutputConfigurator() {
+  RecordPreviousStateUMA();
+}
+
+void OutputConfigurator::Init(bool is_panel_fitting_enabled,
+                              bool is_first_run_after_boot) {
   if (!is_running_on_chrome_os_)
     return;
 
   is_panel_fitting_enabled_ = is_panel_fitting_enabled;
 
   // Cache the initial output state.
   Display* display = base::MessagePumpAuraX11::GetDefaultXDisplay();
   CHECK(display != NULL);
   XGrabServer(display);
   Window window = DefaultRootWindow(display);
   XRRScreenResources* screen = GetScreenResourcesAndRecordUMA(display, window);
   CHECK(screen != NULL);
 
   // Detect our initial state.
   std::vector<OutputSnapshot> outputs = GetDualOutputs(display, screen);
   connected_output_count_ = outputs.size();
+
+  if (is_first_run_after_boot && outputs.size() > 1) {
+    // Configuring the CRTC/Framebuffer clears the boot screen image.
+    // Set the same background color (0xfefefe) while configuring the
+    // display to minimize the duration of black screen at boot
+    // time. The background will be removed when
+    // aura::RootWindowHostLinux is created.
+    // crbug.com/171050.
+    XColor color;
+    Colormap colormap = DefaultColormap(display, 0);
+    char chromeos_backcolor[] = "#FEFEFE";

[Daniel Erat, 2013/01/26 15:52:30]

don't hardcode this here; i think it's defined as a constant somewhere else
(maybe under ui, though... it'd still be best to keep it in a single place so
it'll be easy to change later)

[oshima, 2013/01/26 23:10:42]

I couldn't find one for sharing, but found this one instead.

const SkColor kChromeOsBootColor = SkColorSetARGB(0xff, 0xfe, 0xfe, 0xfe);

I moved it to ash_constants.h.

+    XParseColor(display, colormap, chromeos_backcolor, &color);
+    XAllocColor(display, colormap, &color);
+    XSetWindowAttributes swa = {0};
+    swa.background_pixel = color.pixel;
+    XChangeWindowAttributes(display, window, CWBackPixel, &swa);
+    XFreeColors(display, colormap, &color.pixel, 1, 0);
+  }
+
   output_state_ = InferCurrentState(display, screen, outputs);
   // Ensure that we are in a supported state with all connected displays powered
   // on.
   OutputState starting_state = GetNextState(display,
                                             screen,
                                             STATE_INVALID,
                                             outputs);
   if (output_state_ != starting_state &&
       EnterState(display,
                  screen,
@@ skipping 14 matching lines @@
   CHECK(DPMSForceLevel(display, DPMSModeOn));
 
   // Relinquish X resources.
   XRRFreeScreenResources(screen);
   XUngrabServer(display);
 
   chromeos::DBusThreadManager::Get()->GetPowerManagerClient()->
       SetIsProjecting(is_projecting);
 }
 
-OutputConfigurator::~OutputConfigurator() {
-  RecordPreviousStateUMA();
-}
-
 bool OutputConfigurator::CycleDisplayMode() {
   VLOG(1) << "CycleDisplayMode";
   if (!is_running_on_chrome_os_)
     return false;
 
   bool did_change = false;
   Display* display = base::MessagePumpAuraX11::GetDefaultXDisplay();
   CHECK(display != NULL);
   XGrabServer(display);
   Window window = DefaultRootWindow(display);
@@ skipping 704 matching lines @@
 // static
 RRMode OutputConfigurator::GetOutputNativeMode(
     const XRROutputInfo* output_info) {
   if (output_info->nmode <= 0)
     return None;
 
   return output_info->modes[0];
 }
 
 }  // namespace chromeos