include/core/SkPostConfig.h - Issue 1207893002: Clean up a few includes, introduce iwyu.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/core/SkPostConfig.h

Issue 1207893002: Clean up a few includes, introduce iwyu. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Avoid hiding includes really deep when we don't need it. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/core/SkPostConfig.h

diff --git a/include/core/SkPostConfig.h b/include/core/SkPostConfig.h

index 2074230ba620130da8af3e9bb22e32f5968a7d61..6f3e2d1fc7e5d579a435c79a3b181d05d97f59e6 100644

--- a/include/core/SkPostConfig.h

+++ b/include/core/SkPostConfig.h

@@ -8,7 +8,7 @@

#ifndef SkPostConfig_DEFINED

#define SkPostConfig_DEFINED

-#if defined(SK_BUILD_FOR_WIN32) || defined(SK_BUILD_FOR_WINCE)

+#if defined(SK_BUILD_FOR_WIN32)

# define SK_BUILD_FOR_WIN

#endif

@@ -215,13 +215,6 @@

#endif

//////////////////////////////////////////////////////////////////////////////////////////////

-#ifndef SK_BUILD_FOR_WINCE

-# include <string.h>

bungeman-skia 2015/07/28 21:20:32 This was somewhat magically providing size_t, NULL

-# include <stdlib.h>

bungeman-skia 2015/07/28 21:20:32 Nothing in SkTypes needs this, and most files don'

-#else

-# define _CMNINTRIN_DECLARE_ONLY

-# include "cmnintrin.h"

-#endif

#if defined SK_DEBUG && defined SK_BUILD_FOR_WIN32

# ifdef free

« no previous file with comments | « include/core/SkMutex.h ('k') | include/core/SkTypes.h » ('j') | no next file with comments »