include/core/SkThread.h - Issue 1207893002: Clean up a few includes, introduce iwyu.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: include/core/SkThread.h

Issue 1207893002: Clean up a few includes, introduce iwyu. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Just a little more cleanup. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright 2006 The Android Open Source Project	2 * Copyright 2006 The Android Open Source Project

3 *	3 *

4 * Use of this source code is governed by a BSD-style license that can be	4 * Use of this source code is governed by a BSD-style license that can be

5 * found in the LICENSE file.	5 * found in the LICENSE file.

6 */	6 */

7	7

8 #ifndef SkThread_DEFINED	8 #ifndef SkThread_DEFINED

9 #define SkThread_DEFINED	9 #define SkThread_DEFINED

10	10

11 // TODO: delete this file, or maybe move the definition of SkThread here.	11 // TODO: delete this file, or maybe move the definition of SkThread here.

12	12

13 #include "SkAtomics.h"	13 #include "SkAtomics.h" // IWYU pragma: export
	mtklein 2015/06/24 22:52:01 iwyu seems like a good way to clean up this file. iwyu seems like a good way to clean up this file. If I'm understanding it right, we _don't_ want export on these? bungeman-skia 2015/06/25 14:45:06 On the one hand, yes, without these exports iwyu w Show quoted text On 2015/06/24 22:52:01, mtklein wrote: > iwyu seems like a good way to clean up this file. If I'm understanding it > right, we _don't_ want export on these? On the one hand, yes, without these exports iwyu will ask you to include one of these directly. On the other hand, we already know all uses of this need to be updated. On the other (third?) hand, having iwyu help clean these up means that it just happens as we go, and we don't have to guess which one (or both) of these to include. I'll remove these.
14 #include "SkMutex.h"	14 #include "SkMutex.h" // IWYU pragma: export

15	15

16 #endif	16 #endif

OLD	NEW

« include/core/SkRefCnt.h ('K') | « include/core/SkRefCnt.h ('k') | include/core/SkTypes.h » ('j') | src/ports/SkDebug_stdio.cpp » ('J')