src/ports/SkDiscardableMemory_none.cpp - Issue 1207893002: Clean up a few includes, introduce iwyu.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/ports/SkDiscardableMemory_none.cpp

Issue 1207893002: Clean up a few includes, introduce iwyu. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Postpone stdlib cleanup. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright 2013 Google Inc.	2 * Copyright 2013 Google Inc.

3 *	3 *

4 * Use of this source code is governed by a BSD-style license that can be	4 * Use of this source code is governed by a BSD-style license that can be

5 * found in the LICENSE file.	5 * found in the LICENSE file.

6 */	6 */

7	7

	8 #include "SkDiscardableMemory.h"

8 #include "SkDiscardableMemoryPool.h"	9 #include "SkDiscardableMemoryPool.h"

9 #include "SkTypes.h"	10

	11 #include <stddef.h>
	mtklein 2015/07/28 22:04:19 I think I'd rather "SkTypes.h" than <stddef.h>, un I think I'd rather "SkTypes.h" than <stddef.h>, unless we switch everything over to include <stdfoo.h> themselves. bungeman-skia 2015/07/29 16:46:23 I'd like to switch to <cstdfoo> directly. I assume Show quoted text On 2015/07/28 22:04:19, mtklein wrote: > I think I'd rather "SkTypes.h" than <stddef.h>, unless we switch everything over > to include <stdfoo.h> themselves. I'd like to switch to <cstdfoo> directly. I assume the reason for any of the standard headers being 'provided' by SkTypes is that in the wild west of the past you may not actually have them, so it might need to synthesize them, or include something else (see history of stdint for a good example). It's fine for SkTypes to include whatever headers it needs for it's own code (which there seems to excessive amounts of, some of it needs to be in SkTemplates.h. and that might want to be broken up a bit too), but I'd like to minimize the amount it purposefully exports (for example stdlib is really big). mtklein 2015/07/29 18:05:02 sgtm Show quoted text On 2015/07/29 16:46:23, bungeman1 wrote: > On 2015/07/28 22:04:19, mtklein wrote: > > I think I'd rather "SkTypes.h" than <stddef.h>, unless we switch everything > over > > to include <stdfoo.h> themselves. > > I'd like to switch to <cstdfoo> directly. I assume the reason for any of the > standard headers being 'provided' by SkTypes is that in the wild west of the > past you may not actually have them, so it might need to synthesize them, or > include something else (see history of stdint for a good example). It's fine for > SkTypes to include whatever headers it needs for it's own code (which there > seems to excessive amounts of, some of it needs to be in SkTemplates.h. and that > might want to be broken up a bit too), but I'd like to minimize the amount it > purposefully exports (for example stdlib is really big). sgtm
10	12

11 SkDiscardableMemory* SkDiscardableMemory::Create(size_t bytes) {	13 SkDiscardableMemory* SkDiscardableMemory::Create(size_t bytes) {

12 return SkGetGlobalDiscardableMemoryPool()->create(bytes);	14 return SkGetGlobalDiscardableMemoryPool()->create(bytes);

13 }	15 }

OLD	NEW

« include/ports/SkFontMgr_indirect.h ('K') | « src/ports/SkDebug_stdio.cpp ('k') | src/ports/SkFontConfigInterface_direct.cpp » ('j') | src/ports/SkFontMgr_android.cpp » ('J')