base/trace_event/trace_event_unittest.cc - Issue 1207823004: PlatformThreadHandle: remove public id() interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/trace_event_unittest.cc

Issue 1207823004: PlatformThreadHandle: remove public id() interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review #14, #16 (upstream 1193303002 for review) Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/trace_event/trace_event_unittest.cc

diff --git a/base/trace_event/trace_event_unittest.cc b/base/trace_event/trace_event_unittest.cc

index d6481291fa6f332767404ce8c4aa9dce006ffc37..a71525975c1030f4ec238c224341595c860659df 100644

--- a/base/trace_event/trace_event_unittest.cc

+++ b/base/trace_event/trace_event_unittest.cc

@@ -1547,7 +1547,7 @@ TEST_F(TraceEventTestFixture, ThreadNames) {

WaitableEvent* task_complete_events[kNumThreads];

for (int i = 0; i < kNumThreads; i++) {

task_complete_events[i] = new WaitableEvent(false, false);

- threads[i]->Start();

+ threads[i]->StartAndWaitForTesting();

gab 2015/07/09 18:19:00 Why is this related to this CL?

Takashi Toyoshima 2015/07/14 10:47:28 This is because now thread_id() can return a valid

thread_ids[i] = threads[i]->thread_id();

threads[i]->task_runner()->PostTask(

FROM_HERE, base::Bind(&TraceManyInstantEvents, i, kNumEvents,

« base/threading/thread.cc ('K') | « base/threading/thread_unittest.cc ('k') | no next file » | no next file with comments »