PlatformThreadHandle: remove public id() interface

base/threading/platform_thread_posix.cc

Index: base/threading/platform_thread_posix.cc
diff --git a/base/threading/platform_thread_posix.cc b/base/threading/platform_thread_posix.cc
index f3a835e54f0b2c56cc02827ee85749a8fb25f214..95cc5d55cda76c2a0bd82e28700a5fc6de89dc78 100644
--- a/base/threading/platform_thread_posix.cc
+++ b/base/threading/platform_thread_posix.cc
@@ -63,8 +63,7 @@ void* ThreadFunc(void* params) {
 
   // Stash the id in the handle so the calling thread has a complete
   // handle, and unblock the parent thread.
-  *(thread_params->handle) = PlatformThreadHandle(pthread_self(),
-                                                  PlatformThread::CurrentId());

[gab, 2015/07/02 12:00:52]

Need to fix platform_thread_win.cc similarly.

[Takashi Toyoshima, 2015/07/02 13:54:58]

I may misunderstand your comment, but I think I already applied a right fix for
Win32.
Note that caller thread blocks until this PlatformThreadHandle is set and
following handle_set is signaled at the next line. I will remove this
restriction in the next CL https://codereview.chromium.org/1150563002/

[gab, 2015/07/02 14:32:34]

Oh oops, no that's not what I meant, but I'd somehow missed the change to
platform_thread_win.cc in this CL (and that is what I thought was missing...).

Are there tests for Thread::id()? To confirm this change doesn't break anything
cross-platform (I don't see anything in thread_unittest.cc)

[Takashi Toyoshima, 2015/07/03 04:22:56]

ThreadIdNameManagerTest seems to depend on base::Thread.thread_id(), but it
would be better to have a simple test in thread_unittest.cc. I'd try adding some
tests.

+  *(thread_params->handle) = PlatformThreadHandle(pthread_self());
   thread_params->handle_set.Signal();
 
   ThreadIdNameManager::GetInstance()->RegisterThread(
@@ -165,7 +164,7 @@ PlatformThreadRef PlatformThread::CurrentRef() {
 
 // static
 PlatformThreadHandle PlatformThread::CurrentHandle() {
-  return PlatformThreadHandle(pthread_self(), CurrentId());
+  return PlatformThreadHandle(pthread_self());
 }
 
 // static