Issue 1207803002: Fix the adjustment to include overflow of negative spacing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1207803002: Fix the adjustment to include overflow of negative spacing (Closed)

Created:
4 years, 10 months ago by Xianzhu

Modified:
4 years, 10 months ago

Reviewers:
eae

CC:
blink-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, blink-reviews-rendering, jchaffraix+rendering

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Fix the adjustment to include overflow of negative spacing BUG=496317 TEST=fast/text/text-letter-spacing.html TEST=fast/text/international/rtl-negative-letter-spacing.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197767

Patch Set 1 #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	Source/core/layout/LayoutBlockFlowLine.cpp	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Xianzhu

I made a mistake about the changed code. The adjustment should not move glyphOverflow to ...

4 years, 10 months ago (2015-06-24 18:05:55 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1207803002/1

4 years, 10 months ago (2015-06-24 18:17:39 UTC) #5

commit-bot: I haz the power

4 years, 10 months ago (2015-06-24 18:59:47 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197767

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages