Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 1207793004: Add additional usage metrics for DOMStringList methods (Closed)

Created:
4 years, 10 months ago by jsbell
Modified:
4 years, 10 months ago
Reviewers:
philipj_slow
CC:
blink-reviews, arv+blink, vivekg, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, vivekg_samsung, Inactive, cmumford, dgrogan, jsbell+idb_chromium.org, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add additional usage metrics for DOMStringList methods We'd like to remove DOMStringList from the web platform in favor of plain old arrays of strings. Usage of the contains() method is low but non-zero, and usage may differ between sources of DOMStringList - Indexed DB vs. Location.ancestorOrigins. Add measurement for the use of the item() method (vs. indexed getter), and for both contains() and item() distinguish between sources of instances. BUG=460726 R=philipj@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197783

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -15 lines) Patch
M Source/core/dom/DOMStringList.h View 2 chunks +16 lines, -5 lines 0 comments Download
M Source/core/dom/DOMStringList.cpp View 1 chunk +32 lines, -2 lines 0 comments Download
M Source/core/dom/DOMStringList.idl View 1 chunk +4 lines, -2 lines 0 comments Download
M Source/core/frame/Location.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/modules/indexeddb/IDBDatabase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/IDBObjectStore.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/IDBRequest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/IDBTransaction.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/InspectorIndexedDBAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
jsbell
I factored the data-gathering part out of https://codereview.chromium.org/966843002/ since actual deprecation warnings don't seem to ...
4 years, 10 months ago (2015-06-24 19:38:35 UTC) #1
philipj_slow
lgtm Yay
4 years, 10 months ago (2015-06-24 22:18:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1207793004/1
4 years, 10 months ago (2015-06-24 22:18:34 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2015-06-24 22:22:24 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197783

Powered by Google App Engine
This is Rietveld 408576698