Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(167)

Issue 1207793002: Remove LayoutTests/plugins/destroy-plugin-from-callback.html (Closed)

Created:
4 years, 10 months ago by eae
Modified:
4 years, 10 months ago
Reviewers:
adamk
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove LayoutTests/plugins/destroy-plugin-from-callback.html Remove test that claims to pass unless it crashes yet times out or fail with a different output more often than not. Given that it was added to catch a regression in the webkit plugin architecture that isn't used by Blink anymore the test is rather pointless at this ponint. R=adamk@chromium.org BUG=503848 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197764

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -43 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/plugins/destroy-plugin-from-callback.html View 1 chunk +0 lines, -40 lines 0 comments Download
D LayoutTests/plugins/destroy-plugin-from-callback-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
adamk
lgtm
4 years, 10 months ago (2015-06-24 17:27:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1207793002/1
4 years, 10 months ago (2015-06-24 17:36:39 UTC) #3
commit-bot: I haz the power
4 years, 10 months ago (2015-06-24 18:41:12 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197764

Powered by Google App Engine
This is Rietveld 408576698