Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 1207753002: DevTools: Reverse priority order of timeline cpu utilization groups. (Closed)

Created:
5 years, 6 months ago by alph
Modified:
5 years, 6 months ago
Reviewers:
pfeldman, yurys
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: Reverse priority order of timeline cpu utilization groups. Keep less intensive categories at the bottom of the chart. BUG=497166 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197927

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/devtools/front_end/timeline/TimelineEventOverview.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (4 generated)
alph
5 years, 6 months ago (2015-06-24 16:48:50 UTC) #2
yurys
I don't see big advantage of the new order over the current one. We may ...
5 years, 6 months ago (2015-06-25 15:40:14 UTC) #5
alph
On 2015/06/25 15:40:14, yurys wrote: > I don't see big advantage of the new order ...
5 years, 6 months ago (2015-06-26 08:54:05 UTC) #6
yurys
On 2015/06/26 08:54:05, alph wrote: > On 2015/06/25 15:40:14, yurys wrote: > > I don't ...
5 years, 6 months ago (2015-06-26 09:08:53 UTC) #7
alph
On 2015/06/26 09:08:53, yurys wrote: > On 2015/06/26 08:54:05, alph wrote: > > On 2015/06/25 ...
5 years, 6 months ago (2015-06-26 09:12:30 UTC) #8
yurys
On 2015/06/26 09:12:30, alph wrote: > On 2015/06/26 09:08:53, yurys wrote: > > On 2015/06/26 ...
5 years, 6 months ago (2015-06-26 09:14:09 UTC) #9
pfeldman
I can see it as being slightly more user-friendly since it produces a more continuous ...
5 years, 6 months ago (2015-06-26 09:18:04 UTC) #10
alph
On 2015/06/26 09:14:09, yurys wrote: > On 2015/06/26 09:12:30, alph wrote: > > On 2015/06/26 ...
5 years, 6 months ago (2015-06-26 09:19:40 UTC) #11
yurys
On 2015/06/26 09:18:04, pfeldman wrote: > I can see it as being slightly more user-friendly ...
5 years, 6 months ago (2015-06-26 09:45:05 UTC) #12
pfeldman
lets try it out? lgtm
5 years, 6 months ago (2015-06-26 15:23:15 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1207753002/1
5 years, 6 months ago (2015-06-26 15:30:13 UTC) #15
commit-bot: I haz the power
5 years, 6 months ago (2015-06-26 16:34:56 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197927

Powered by Google App Engine
This is Rietveld 408576698