Fix unexpected token messages in expression classifier

Fix unexpected token messages in expression classifier

Some tokens need special messages because their token corresponds to
many names.

R=arv@chromium.org
BUG=v8:4213
LOG=N

Committed: https://crrev.com/edcc242a44eb0441d88b881b8d9ec6c4225c6c2e
Cr-Commit-Position: refs/heads/master@{#29262}

[wingo, 2015-06-24 16:46:50]

This is a partial fix for http://code.google.com/p/v8/issues/detail?id=4213
because really we have dedicated errors for this case and should be signalling
them.

[wingo, 2015-06-24 16:47:25]

On 2015/06/24 16:46:50, wingo wrote:
> This is a partial fix for http://code.google.com/p/v8/issues/detail?id=4213
> because really we have dedicated errors for this case and should be signalling
> them.

with this patch behavior improves:

d8> function f() { "use strict"; eval => {} }
(d8):1: SyntaxError: Unexpected identifier
function f() { "use strict"; eval => {} }
                             ^^^^
SyntaxError: Unexpected identifier

[arv (Not doing code reviews), 2015-06-24 16:47:54]

On 2015/06/24 16:47:25, wingo wrote:
> On 2015/06/24 16:46:50, wingo wrote:
> > This is a partial fix for http://code.google.com/p/v8/issues/detail?id=4213
> > because really we have dedicated errors for this case and should be
signalling
> > them.
> 
> with this patch behavior improves:
> 
> d8> function f() { "use strict"; eval => {} }
> (d8):1: SyntaxError: Unexpected identifier
> function f() { "use strict"; eval => {} }
>                              ^^^^
> SyntaxError: Unexpected identifier

Maybe add a test/messages test too?

[arv (Not doing code reviews), 2015-06-24 16:52:46]

LGTM

[wingo, 2015-06-24 16:54:23]

On 2015/06/24 16:52:46, arv wrote:
> LGTM

Thanks; added a message test.  Will follow up if I find a way to make it signal
the right error.

[wingo, 2015-06-24 16:54:32]

The CQ bit was checked by wingo@igalia.com

[wingo, 2015-06-24 16:54:33]

The patchset sent to the CQ was uploaded after l-g-t-m from arv@chromium.org
Link to the patchset: https://codereview.chromium.org/1207743004/#ps20001
(title: "Add message test")

[commit-bot: I haz the power, 2015-06-24 16:54:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1207743004/20001

[arv (Not doing code reviews), 2015-06-24 16:58:24]

Still LGTM

[commit-bot: I haz the power, 2015-06-24 17:25:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-06-24 17:25:36]

Patchset 2 (id:??) landed as
https://crrev.com/edcc242a44eb0441d88b881b8d9ec6c4225c6c2e
Cr-Commit-Position: refs/heads/master@{#29262}