Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 120773003: Ported media stream track enable-disable test to content module. (Closed)

Created:
6 years, 11 months ago by phoglund_chromium
Modified:
6 years, 11 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Visibility:
Public.

Description

Ported media stream track enable-disable test to content module. Also improves the tests to check that audio muting doesn't mute video and vice versa. BUG=328196, 331045 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243591

Patch Set 1 #

Total comments: 8

Patch Set 2 : Addressed perkj's comments #

Total comments: 1

Patch Set 3 : Adding bug id to disable comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -71 lines) Patch
M chrome/browser/media/chrome_webrtc_browsertest.cc View 3 chunks +0 lines, -57 lines 0 comments Download
M content/browser/media/webrtc_browsertest.cc View 1 2 2 chunks +13 lines, -0 lines 0 comments Download
M content/test/data/media/peerconnection-call.html View 1 4 chunks +44 lines, -11 lines 0 comments Download
M content/test/data/media/webrtc_test_utilities.js View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
phoglund_chromium
6 years, 11 months ago (2014-01-02 17:09:46 UTC) #1
phoglund_chromium
perkj: main review tommi: owner stamp
6 years, 11 months ago (2014-01-02 17:10:45 UTC) #2
perkj_chrome
https://codereview.chromium.org/120773003/diff/1/content/browser/media/webrtc_browsertest.cc File content/browser/media/webrtc_browsertest.cc (right): https://codereview.chromium.org/120773003/diff/1/content/browser/media/webrtc_browsertest.cc#newcode462 content/browser/media/webrtc_browsertest.cc:462: // stable in the second negotiation round rather than ...
6 years, 11 months ago (2014-01-07 06:51:26 UTC) #3
phoglund_chromium
PTAL https://codereview.chromium.org/120773003/diff/1/content/browser/media/webrtc_browsertest.cc File content/browser/media/webrtc_browsertest.cc (right): https://codereview.chromium.org/120773003/diff/1/content/browser/media/webrtc_browsertest.cc#newcode462 content/browser/media/webrtc_browsertest.cc:462: // stable in the second negotiation round rather ...
6 years, 11 months ago (2014-01-07 14:41:59 UTC) #4
perkj_chrome
lgtm. Can you add the defect number to your comment? https://codereview.chromium.org/120773003/diff/80001/content/browser/media/webrtc_browsertest.cc File content/browser/media/webrtc_browsertest.cc (right): https://codereview.chromium.org/120773003/diff/80001/content/browser/media/webrtc_browsertest.cc#newcode453 ...
6 years, 11 months ago (2014-01-08 08:55:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phoglund@chromium.org/120773003/140001
6 years, 11 months ago (2014-01-08 13:12:19 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=43781
6 years, 11 months ago (2014-01-08 13:32:02 UTC) #7
no longer working on chromium
On 2014/01/08 13:32:02, I haz the power (commit-bot) wrote: > Retried try job too often ...
6 years, 11 months ago (2014-01-08 14:13:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phoglund@chromium.org/120773003/140001
6 years, 11 months ago (2014-01-08 14:32:26 UTC) #9
commit-bot: I haz the power
6 years, 11 months ago (2014-01-08 17:34:44 UTC) #10
Message was sent while issue was closed.
Change committed as 243591

Powered by Google App Engine
This is Rietveld 408576698