Revert "JSInvocationMirror - return unmodifiable list or map"

sdk/lib/_internal/compiler/js_lib/js_helper.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library _js_helper;
 
 import 'dart:_async_await_error_codes' as async_error_codes;
 
 import 'dart:_js_embedded_names' show
     DEFERRED_LIBRARY_URIS,
@@ skipping 282 matching lines @@
   bool get isAccessor => _kind != METHOD;
 
   List get positionalArguments {
     if (isGetter) return const [];
     var argumentCount = _arguments.length - _namedArgumentNames.length;
     if (argumentCount == 0) return const [];
     var list = [];
     for (var index = 0 ; index < argumentCount ; index++) {
       list.add(_arguments[index]);
     }
-    return JSArray.markUnmodifiableList(list);
+    return makeLiteralListConst(list);
   }
 
   Map<Symbol, dynamic> get namedArguments {
-    if (isAccessor) return const <Symbol, dynamic>{};
+    // TODO: Make maps const (issue 10471)
+    if (isAccessor) return <Symbol, dynamic>{};
     int namedArgumentCount = _namedArgumentNames.length;
     int namedArgumentsStartIndex = _arguments.length - namedArgumentCount;
-    if (namedArgumentCount == 0) return const <Symbol, dynamic>{};
+    if (namedArgumentCount == 0) return <Symbol, dynamic>{};
     var map = new Map<Symbol, dynamic>();
     for (int i = 0; i < namedArgumentCount; i++) {
       map[new _symbol_dev.Symbol.unvalidated(_namedArgumentNames[i])] =
           _arguments[namedArgumentsStartIndex + i];
     }
-    return new ConstantMapView<Symbol, dynamic>(map);
+    return map;
   }
 
   _getCachedInvocation(Object object) {
     var interceptor = getInterceptor(object);
     var receiver = object;
     var name = _internalName;
     var arguments = _arguments;
     var interceptedNames = JS_EMBEDDED_GLOBAL('', INTERCEPTED_NAMES);
     bool isIntercepted =
         JS("bool", 'Object.prototype.hasOwnProperty.call(#, #)',
@@ skipping 1170 matching lines @@
 /**
  * This wraps the exception and does the throw.  It is possible to call this in
  * a JS expression context, where the throw statement is not allowed.  Helpers
  * are never inlined, so we don't risk inlining the throw statement into an
  * expression context.
  */
 throwExpression(ex) {
   JS('void', 'throw #', wrapException(ex));
 }
 
+makeLiteralListConst(list) {
+  JS('bool', r'#.immutable$list = #', list, true);
+  JS('bool', r'#.fixed$length = #', list, true);
+  return list;
+}
+
 throwRuntimeError(message) {
   throw new RuntimeError(message);
 }
 
 throwAbstractClassInstantiationError(className) {
   throw new AbstractClassInstantiationError(className);
 }
 
 // This is used in open coded for-in loops on arrays.
 //
@@ skipping 2605 matching lines @@
   // This is a function that will return a helper function that does the
   // iteration of the sync*.
   //
   // Each invocation should give a body with fresh state.
   final dynamic /* js function */ _outerHelper;
 
   SyncStarIterable(this._outerHelper);
 
   Iterator get iterator => new SyncStarIterator(JS('', '#()', _outerHelper));
 }