Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/app_controller_mac.mm

Issue 12077030: Allow signin to continue even if sync is disabled by policy. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address review feedback. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/autofill/autofill_manager_unittest.cc » ('j') | chrome/browser/signin/fake_auth_status_provider.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/app_controller_mac.mm
diff --git a/chrome/browser/app_controller_mac.mm b/chrome/browser/app_controller_mac.mm
index b5d026d21c506f1641c336b9c369d36b0441bbd1..52d316801e5050fc02fffb9cd52f9df273b5f057 100644
--- a/chrome/browser/app_controller_mac.mm
+++ b/chrome/browser/app_controller_mac.mm
@@ -778,8 +778,7 @@ void RecordLastRunAppBundlePath() {
<< "NULL lastProfile detected -- not doing anything";
break;
}
- enable = lastProfile->IsSyncAccessible() &&
- ![self keyWindowIsModal];
+ enable = ![self keyWindowIsModal];
[BrowserWindowController updateSigninItem:item
shouldShow:enable
currentProfile:lastProfile];
@@ -918,7 +917,7 @@ void RecordLastRunAppBundlePath() {
break;
case IDC_SHOW_SYNC_SETUP:
if (Browser* browser = ActivateBrowser(lastProfile))
- chrome::ShowSyncSetup(browser, SyncPromoUI::SOURCE_MENU);
+ chrome::ShowBrowserSignin(browser, SyncPromoUI::SOURCE_MENU);
else
chrome::OpenSyncSetupWindow(lastProfile, SyncPromoUI::SOURCE_MENU);
break;
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/autofill/autofill_manager_unittest.cc » ('j') | chrome/browser/signin/fake_auth_status_provider.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698