Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1080)

Unified Diff: chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc

Issue 12077030: Allow signin to continue even if sync is disabled by policy. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix windows sync integration test failure Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc
diff --git a/chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc b/chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc
index cb140efddbb54b6441f5e7e17b76d8a5d0309585..dd8a79ec53d48a23d43dc0d21dde074c1a3c8ca3 100644
--- a/chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc
+++ b/chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc
@@ -16,6 +16,8 @@
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/profiles/profile_info_cache.h"
#include "chrome/browser/profiles/profile_manager.h"
+#include "chrome/browser/signin/signin_manager.h"
+#include "chrome/browser/signin/signin_manager_factory.h"
#include "chrome/browser/sync/profile_sync_service.h"
#include "chrome/browser/sync/profile_sync_service_factory.h"
#include "chrome/browser/ui/webui/options/core_options_handler.h"
@@ -119,25 +121,17 @@ bool SyncPromoUI::ShouldShowSyncPromo(Profile* profile) {
// There's no need to show the sync promo on cros since cros users are logged
// into sync already.
return false;
-#endif
+#else
// Don't bother if we don't have any kind of network connection.
if (net::NetworkChangeNotifier::IsOffline())
return false;
- // Honor the sync policies.
- if (!profile->GetOriginalProfile()->IsSyncAccessible())
- return false;
-
- // If the user is already signed into sync then don't show the promo.
- ProfileSyncService* service =
- ProfileSyncServiceFactory::GetInstance()->GetForProfile(
- profile->GetOriginalProfile());
- if (!service || service->HasSyncSetupCompleted())
- return false;
-
- // Default to allow the promo.
- return true;
+ // Display the signin promo if the user is not signed in.
+ SigninManager* signin = SigninManagerFactory::GetForProfile(
+ profile->GetOriginalProfile());
+ return signin->GetAuthenticatedUsername().empty();
+#endif
}
// static
« no previous file with comments | « chrome/browser/ui/webui/options/browser_options_handler.cc ('k') | chrome/browser/ui/webui/sync_setup_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698