chrome/browser/extensions/api/web_request/web_request_apitest.cc - Issue 12077029: Removing the Dev channel restriction for requestBody of Web Request API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_request/web_request_apitest.cc

Issue 12077029: Removing the Dev channel restriction for requestBody of Web Request API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/web_request/web_request_api_unittest.cc ('K') | « chrome/browser/extensions/api/web_request/web_request_api_unittest.cc ('k') | chrome/common/extensions/api/web_request.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_request/web_request_apitest.cc

diff --git a/chrome/browser/extensions/api/web_request/web_request_apitest.cc b/chrome/browser/extensions/api/web_request/web_request_apitest.cc

index 66cebfb4e6e0a3cc56109dac9ff2df8e6d7dfd00..b7122bb2283ca9e1ca0df4b6d9413ce2ecceea37 100644

--- a/chrome/browser/extensions/api/web_request/web_request_apitest.cc

+++ b/chrome/browser/extensions/api/web_request/web_request_apitest.cc

@@ -245,16 +245,12 @@ IN_PROC_BROWSER_TEST_F(ExtensionWebRequestApiTest,

}

IN_PROC_BROWSER_TEST_F(ExtensionWebRequestApiTest, PostData1) {

- // Request body access is only enabled on dev (and canary).

- Feature::ScopedCurrentChannel sc(chrome::VersionInfo::CHANNEL_DEV);

// Test HTML form POST data access with the default and "url" encoding.

ASSERT_TRUE(RunExtensionSubtest("webrequest", "test_post1.html")) <<

message_;

}

IN_PROC_BROWSER_TEST_F(ExtensionWebRequestApiTest, PostData2) {

- // Request body access is only enabled on dev (and canary).

- Feature::ScopedCurrentChannel sc(chrome::VersionInfo::CHANNEL_DEV);

// Test HTML form POST data access with the multipart and plaintext encoding.

ASSERT_TRUE(RunExtensionSubtest("webrequest", "test_post2.html")) <<

message_;