Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: LayoutTests/inspector/tracing/timeline-js-samping-codeobject-names.html

Issue 1207693003: DevTools: Skip native frames on timeline JS profiler. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: addressing comments. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/inspector/tracing/timeline-js-samping-codeobject-names-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/inspector/tracing/timeline-js-samping-codeobject-names.html
diff --git a/LayoutTests/inspector/tracing/timeline-js-samping-codeobject-names.html b/LayoutTests/inspector/tracing/timeline-js-samping-codeobject-names.html
index 6034546cc1e90c2eae8f83a5cb48aafe0a955a96..8e50ee1e4c0e08889242eac8f54cd2133064a51b 100644
--- a/LayoutTests/inspector/tracing/timeline-js-samping-codeobject-names.html
+++ b/LayoutTests/inspector/tracing/timeline-js-samping-codeobject-names.html
@@ -15,16 +15,20 @@ function test()
"Script:http://example.com/:1:2:3",
"Script:http://example.com/:1:2:3x:4",
"Builtin:~foo1 http://url.com/foo.js",
- "Builtin:~foo2 http://url.com/foo.js:11",
+ "Builtin:~foo2 native http://url.com/foo.js:11",
"Builtin:*foo3 http://url.com/foo.js:11:22",
"Builtin:foo4 http://url.com/foo.js:11:22:33",
"Builtin:~ http://url.com/anonymous.js:123",
- "Builtin:~function name with spaces http://url.com/anonymous.js:123"
+ "Builtin:~ native http://url.com/anonymous.js:123",
+ "Builtin:~function name with spaces http://url.com/bar:123",
+ "Builtin:~native function name with spaces native http://url.com/bar.js:123",
+ "Builtin:~user_function_that_is_not_native http://url.com/bar.js:123",
+ "Builtin:~native http://url.com/bar.js:123"
];
for (var name of rawNames) {
var frame = WebInspector.TimelineJSProfileProcessor._buildCallFrame(name, "456");
- InspectorTest.addResult(name + " => " + [frame.functionName, frame.url, frame.scriptId, frame.lineNumber, frame.columnNumber].join(","));
+ InspectorTest.addResult(name + " => " + [frame.functionName, frame.url, frame.scriptId, frame.lineNumber, frame.columnNumber, frame.isNative].join(","));
}
InspectorTest.completeTest();
« no previous file with comments | « no previous file | LayoutTests/inspector/tracing/timeline-js-samping-codeobject-names-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698