DevTools: Skip native frames on timeline JS profiler.

Source/devtools/front_end/timeline/TimelineJSProfile.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 
 WebInspector.TimelineJSProfileProcessor = { };
 
 /**
  * @param {!ProfilerAgent.CPUProfile} jsProfile
  * @param {!WebInspector.TracingModel.Thread} thread
@@ skipping 233 matching lines @@
     },
 
     /**
      * @param {string} oldAddressHex
      * @param {string} newAddressHex
      * @param {number} size
      */
     moveEntry: function(oldAddressHex, newAddressHex, size)
     {
         var entry = this._getBank(oldAddressHex).removeEntry(this._getAddress(oldAddressHex));
-        if (!entry) {
-            console.error("Entry at address " + oldAddressHex + " not found");

[yurys, 2015/06/24 13:57:44]

Why was this removed? Is there a valid case when we don't know the old address?

[alph, 2015/06/24 14:03:38]

Reverted.

+        if (!entry)
             return;
-        }
         entry.address = this._getAddress(newAddressHex);
         entry.size = size;
         this._addEntry(newAddressHex, entry);
     },
 
     /**
      * @param {string} addressHex
      * @return {?ConsoleAgent.CallFrame}
      */
     lookupEntry: function(addressHex)
@@ skipping 91 matching lines @@
             var entryEndAddress = entry.address + entry.size;
             if (entryEndAddress <= newEntry.address)
                 break;
         }
         ++index;
         this._entries.splice(index, lastIndex - index, newEntry);
     }
 }
 
 /**
- * @param {string} functionName
- * @param {string=} url
- * @param {string=} scriptId
- * @param {number=} line
- * @param {number=} column
- * @return {!ConsoleAgent.CallFrame}
- */
-WebInspector.TimelineJSProfileProcessor._createFrame = function(functionName, url, scriptId, line, column)
-{
-    return /** @type {!ConsoleAgent.CallFrame} */ ({
-        "functionName": functionName,
-        "url": url || "",
-        "scriptId": scriptId || "0",
-        "lineNumber": line || 0,
-        "columnNumber": column || 0
-    });
-}
-
-/**
  * @param {string} name
  * @param {number} scriptId
  * @return {!ConsoleAgent.CallFrame}
  */
 WebInspector.TimelineJSProfileProcessor._buildCallFrame = function(name, scriptId)
 {
+    /**
+     * @param {string} functionName
+     * @param {string=} url
+     * @param {string=} scriptId
+     * @param {number=} line
+     * @param {number=} column
+     * @param {boolean=} isNative
+     * @return {!ConsoleAgent.CallFrame}
+     */
+    function createFrame(functionName, url, scriptId, line, column, isNative)
+    {
+        return /** @type {!ConsoleAgent.CallFrame} */ ({
+            "functionName": functionName,
+            "url": url || "",
+            "scriptId": scriptId || "0",
+            "lineNumber": line || 0,
+            "columnNumber": column || 0,
+            "isNative": isNative || false
+        });
+    }
+
     // Code states:
     // (empty) -> compiled
     //    ~    -> optimizable
     //    *    -> optimized
     var rePrefix = /^(\w*:)?[*~]?(.*)$/m;
-
     var tokens = rePrefix.exec(name);
     var prefix = tokens[1];
     var body = tokens[2];
     var rawName;
     var rawUrl;
     if (prefix === "Script:") {
         rawName = "";
         rawUrl = body;
     } else {
         var spacePos = body.lastIndexOf(" ");
         rawName = spacePos !== -1 ? body.substr(0, spacePos) : body;
         rawUrl = spacePos !== -1 ? body.substr(spacePos + 1) : "";
     }
-    var functionName = rawName;
+    var nativeSuffix = " native";
+    var isNative = rawName.endsWith(nativeSuffix);
+    var functionName = isNative ? rawName.slice(0, -nativeSuffix.length) : rawName;
     var urlData = WebInspector.ParsedURL.splitLineAndColumn(rawUrl);
     var url = urlData.url || "";
     var line = urlData.lineNumber || 0;
     var column = urlData.columnNumber || 0;
-    return WebInspector.TimelineJSProfileProcessor._createFrame(functionName, url, String(scriptId), line, column);
+    return createFrame(functionName, url, String(scriptId), line, column, isNative);
 }
 
 /**
  * @param {!Array<!WebInspector.TracingModel.Event>} events
  * @return {!Array<!WebInspector.TracingModel.Event>}
  */
 WebInspector.TimelineJSProfileProcessor.processRawV8Samples = function(events)
 {
     var missingAddesses = new Set();
 
     /**
      * @param {string} address
-     * @return {!ConsoleAgent.CallFrame}
+     * @return {?ConsoleAgent.CallFrame}
      */
     function convertRawFrame(address)
     {
         var entry = codeMap.lookupEntry(address);
         if (entry)
-            return entry;
+            return !entry.isNative ? entry : null;

[yurys, 2015/06/24 13:57:44]

entry.isNative ? null : entry;

[alph, 2015/06/24 14:03:38]

Done.

         if (!missingAddesses.has(address)) {
             missingAddesses.add(address);
             console.error("Address " + address + " has missing code entry");
         }
-        return WebInspector.TimelineJSProfileProcessor._createFrame(address);
+        return null;
     }
 
     var recordTypes = WebInspector.TimelineModel.RecordType;
     var samples = [];
     var codeMap = new WebInspector.TimelineJSProfileProcessor.CodeMap();
     for (var i = 0; i < events.length; ++i) {
         var e = events[i];
         var data = e.args["data"];
         switch (e.name) {
         case recordTypes.JitCodeAdded:
             var frame = WebInspector.TimelineJSProfileProcessor._buildCallFrame(data["name"], data["script_id"]);
             codeMap.addEntry(data["code_start"], data["code_len"], frame);
             break;
         case recordTypes.JitCodeMoved:
             codeMap.moveEntry(data["code_start"], data["new_code_start"], data["code_len"]);
             break;
         case recordTypes.V8Sample:
             var rawStack = data["stack"];
             // Sometimes backend fails to collect a stack and returns an empty stack.
             // Skip these bogus samples.
             if (data["vm_state"] === "js" && !rawStack.length)
                 break;
             var stack = rawStack.map(convertRawFrame);
+            stack.remove(null);
             var sampleEvent = new WebInspector.TracingModel.Event(
                 WebInspector.TracingModel.DevToolsTimelineEventCategory,
                 WebInspector.TimelineModel.RecordType.JSSample,
                 WebInspector.TracingModel.Phase.Instant, e.startTime, e.thread);
             sampleEvent.ordinal = e.ordinal;
             sampleEvent.args = {"data": {"stackTrace": stack }};
             samples.push(sampleEvent);
             break;
         }
     }
 
     return samples;
 }