Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 1207693003: DevTools: Skip native frames on timeline JS profiler. (Closed)

Created:
5 years, 6 months ago by alph
Modified:
5 years, 6 months ago
Reviewers:
yurys
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: Skip native frames on timeline JS profiler. Skip native frames on timeline tracing-based JS profiler. It is made to align them with the stacks collected with capture option. These do not include native functions. BUG=406277 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197746

Patch Set 1 #

Total comments: 4

Patch Set 2 : addressing comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -41 lines) Patch
M LayoutTests/inspector/tracing/timeline-js-samping-codeobject-names.html View 1 chunk +7 lines, -3 lines 0 comments Download
M LayoutTests/inspector/tracing/timeline-js-samping-codeobject-names-expected.txt View 1 chunk +17 lines, -13 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineJSProfile.js View 1 4 chunks +29 lines, -25 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
alph
5 years, 6 months ago (2015-06-24 13:21:08 UTC) #2
yurys
lgtm https://codereview.chromium.org/1207693003/diff/1/Source/devtools/front_end/timeline/TimelineJSProfile.js File Source/devtools/front_end/timeline/TimelineJSProfile.js (left): https://codereview.chromium.org/1207693003/diff/1/Source/devtools/front_end/timeline/TimelineJSProfile.js#oldcode255 Source/devtools/front_end/timeline/TimelineJSProfile.js:255: console.error("Entry at address " + oldAddressHex + " ...
5 years, 6 months ago (2015-06-24 13:57:45 UTC) #3
alph
https://codereview.chromium.org/1207693003/diff/1/Source/devtools/front_end/timeline/TimelineJSProfile.js File Source/devtools/front_end/timeline/TimelineJSProfile.js (left): https://codereview.chromium.org/1207693003/diff/1/Source/devtools/front_end/timeline/TimelineJSProfile.js#oldcode255 Source/devtools/front_end/timeline/TimelineJSProfile.js:255: console.error("Entry at address " + oldAddressHex + " not ...
5 years, 6 months ago (2015-06-24 14:03:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1207693003/20001
5 years, 6 months ago (2015-06-24 14:04:08 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 15:26:37 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197746

Powered by Google App Engine
This is Rietveld 408576698