Source/core/editing/SelectionController.h - Issue 1207663002: Simplify the SelectionConroller class with selection() instead of frame->selection()

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/editing/SelectionController.h

Issue 1207663002: Simplify the SelectionConroller class with selection() instead of frame->selection() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | Source/core/editing/SelectionController.cpp » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved.	2 * Copyright (C) 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved.

3 * Copyright (C) 2015 Google Inc. All rights reserved.	3 * Copyright (C) 2015 Google Inc. All rights reserved.

4 *	4 *

5 * Redistribution and use in source and binary forms, with or without	5 * Redistribution and use in source and binary forms, with or without

6 * modification, are permitted provided that the following conditions	6 * modification, are permitted provided that the following conditions

7 * are met:	7 * are met:

8 * 1. Redistributions of source code must retain the above copyright	8 * 1. Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * 2. Redistributions in binary form must reproduce the above copyright	10 * 2. Redistributions in binary form must reproduce the above copyright

(...skipping 63 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
74 template <typename Strategy>	74 template <typename Strategy>

75 void updateSelectionForMouseDragAlgorithm(const HitTestResult&, Node*, const LayoutPoint&, const IntPoint&);	75 void updateSelectionForMouseDragAlgorithm(const HitTestResult&, Node*, const LayoutPoint&, const IntPoint&);

76	76

77 enum class AppendTrailingWhitespace { ShouldAppend, DontAppend };	77 enum class AppendTrailingWhitespace { ShouldAppend, DontAppend };

78 void selectClosestWordFromHitTestResult(const HitTestResult&, AppendTrailing Whitespace);	78 void selectClosestWordFromHitTestResult(const HitTestResult&, AppendTrailing Whitespace);

79 void selectClosestMisspellingFromHitTestResult(const HitTestResult&, AppendT railingWhitespace);	79 void selectClosestMisspellingFromHitTestResult(const HitTestResult&, AppendT railingWhitespace);

80 void selectClosestWordFromMouseEvent(const MouseEventWithHitTestResults&);	80 void selectClosestWordFromMouseEvent(const MouseEventWithHitTestResults&);

81 void selectClosestMisspellingFromMouseEvent(const MouseEventWithHitTestResul ts&);	81 void selectClosestMisspellingFromMouseEvent(const MouseEventWithHitTestResul ts&);

82 void selectClosestWordOrLinkFromMouseEvent(const MouseEventWithHitTestResult s&);	82 void selectClosestWordOrLinkFromMouseEvent(const MouseEventWithHitTestResult s&);

83	83

	84 FrameSelection& selection() const;

84	85

85 RawPtrWillBeMember<LocalFrame> const m_frame;	86 RawPtrWillBeMember<LocalFrame> const m_frame;

86 bool m_mouseDownMayStartSelect;	87 bool m_mouseDownMayStartSelect;

87 bool m_mouseDownWasSingleClickInSelection;	88 bool m_mouseDownWasSingleClickInSelection;

88 enum class SelectionState { HaveNotStartedSelection, PlacedCaret, ExtendedSe lection };	89 enum class SelectionState { HaveNotStartedSelection, PlacedCaret, ExtendedSe lection };

89 SelectionState m_selectionState;	90 SelectionState m_selectionState;

90 };	91 };

91	92

92 } // namespace blink	93 } // namespace blink

93 #endif // SelectionController_h	94 #endif // SelectionController_h

OLD	NEW