Simplify the SelectionConroller class with selection() instead of frame->selection()

Simplify the SelectionConroller class with selection() instead of frame->selection()

BUG=483376
TEST=n/a; No behavior changes.
R=yosin@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197808

[yosin_UTC9, 2015-06-24 09:26:39]

https://codereview.chromium.org/1207663002/diff/1/Source/core/editing/Selecti...
File Source/core/editing/SelectionController.cpp (right):

https://codereview.chromium.org/1207663002/diff/1/Source/core/editing/Selecti...
Source/core/editing/SelectionController.cpp:111: bool
SelectionController::updateSelectionForMouseDownDispatchingSelectStart(Node*
targetNode, const VisibleSelection& visibleSelection, TextGranularity
granularity)
We don't need to rename this parameter name, this function doesn't use both
|selection| and |selection()|.

If we need to use both |selection()| and |selection|, we usually write as
|selection = this->selection()|.

[Miyoung Shin(c), 2015-06-24 10:51:03]

https://codereview.chromium.org/1207663002/diff/1/Source/core/editing/Selecti...
File Source/core/editing/SelectionController.cpp (right):

https://codereview.chromium.org/1207663002/diff/1/Source/core/editing/Selecti...
Source/core/editing/SelectionController.cpp:111: bool
SelectionController::updateSelectionForMouseDownDispatchingSelectStart(Node*
targetNode, const VisibleSelection& visibleSelection, TextGranularity
granularity)
On 2015/06/24 09:26:39, Yosi_UTC9 wrote:
> We don't need to rename this parameter name, this function doesn't use both
> |selection| and |selection()|.
> 
> If we need to use both |selection()| and |selection|, we usually write as
> |selection = this->selection()|.

Done. Thanks for your kind comment.

[yosin_UTC9, 2015-06-25 00:59:54]

lgtm

Thanks!

[yosin_UTC9, 2015-06-25 00:59:58]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2015-06-25 01:00:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1207663002/20001

[commit-bot: I haz the power, 2015-06-25 01:02:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-25 01:02:36]

Try jobs failed on following builders:
  mac_blink_compile_dbg on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/bu...)

[yosin_UTC9, 2015-06-25 03:34:26]

On 2015/06/25 01:02:36, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   mac_blink_compile_dbg on tryserver.blink (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/bu...)

Sorry, bots failed to apply patch, please rebase your patch.

[Miyoung Shin(c), 2015-06-25 05:05:10]

On 2015/06/25 03:34:26, Yosi_UTC9 wrote:
> On 2015/06/25 01:02:36, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   mac_blink_compile_dbg on tryserver.blink (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/bu...)
> 
> Sorry, bots failed to apply patch, please rebase your patch.

Rebased.

[Miyoung Shin(c), 2015-06-25 05:37:23]

The CQ bit was checked by myid.shin@chromium.org

[Miyoung Shin(c), 2015-06-25 05:37:23]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/1207663002/#ps40001
(title: "Rebase")

[Miyoung Shin(c), 2015-06-25 06:27:00]

The CQ bit was unchecked by myid.shin@chromium.org

[Miyoung Shin(c), 2015-06-25 07:35:27]

The CQ bit was checked by myid.shin@chromium.org

[commit-bot: I haz the power, 2015-06-25 09:01:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1207663002/40001

[commit-bot: I haz the power, 2015-06-25 09:35:02]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197808