Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 120763003: Revert r19394 - "Revert r18390 - "Roll gyp 1685:1806"" (Closed)

Created:
6 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Visibility:
Public.

Description

Revert r19394 - "Revert r18390 - "Roll gyp 1685:1806"" Also include a gyp_v8.py wrapper for new import rules. > Doesn't work with python2.7 - I tested with 2.6 :-/ > > BUG=none > TBR=hpayer@chromium.org > LOG=n BUG=none LOG=n R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18433

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -18 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M Makefile View 1 chunk +1 line, -1 line 0 comments Download
A + build/gyp_v8.py View 1 chunk +11 lines, -16 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
6 years, 11 months ago (2014-01-02 09:35:03 UTC) #1
Benedikt Meurer
LGTM
6 years, 11 months ago (2014-01-02 09:55:38 UTC) #2
jochen (gone - plz use gerrit)
6 years, 11 months ago (2014-01-02 09:58:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18433 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698