Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 1207613005: Move reconfiguration into the elements accessor (Closed)

Created:
5 years, 6 months ago by Toon Verwaest
Modified:
5 years, 6 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move reconfiguration into the elements accessor BUG=v8:4137 LOG=n Committed: https://crrev.com/f461c7a67aa1d6aaeadd30b2ab1514d6ee3cf4a7 Cr-Commit-Position: refs/heads/master@{#29289}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -98 lines) Patch
M src/elements.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/elements.cc View 4 chunks +81 lines, -3 lines 0 comments Download
M src/lookup.cc View 1 chunk +5 lines, -12 lines 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -83 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Toon Verwaest
ptal
5 years, 6 months ago (2015-06-24 11:50:11 UTC) #2
Igor Sheludko
Nice! lgtm
5 years, 6 months ago (2015-06-24 15:14:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1207613005/1
5 years, 6 months ago (2015-06-25 10:55:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-25 11:26:05 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-25 11:26:21 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f461c7a67aa1d6aaeadd30b2ab1514d6ee3cf4a7
Cr-Commit-Position: refs/heads/master@{#29289}

Powered by Google App Engine
This is Rietveld 408576698