third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp - Issue 1207613004: Fix leaking AXNodeObjects when sub document detaches

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp

Issue 1207613004: Fix leaking AXNodeObjects when sub document detaches (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebased Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.cpp ('k') | third_party/WebKit/Source/modules/accessibility/AXSVGRoot.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp

diff --git a/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp b/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp

index dd38c52ffd845461352cb724f04884cb149bffc5..f5a7b285e145933941a213ac8dabfa49f07a4c3b 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp

+++ b/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp

@@ -2142,6 +2142,7 @@ static Node* getParentNodeForComputeParent(Node* node)

AXObject* AXNodeObject::computeParent() const

{

+ ASSERT(!isDetached());

if (Node* parentNode = getParentNodeForComputeParent(node()))

return axObjectCache().getOrCreate(parentNode);

@@ -2183,6 +2184,7 @@ AXObject* AXNodeObject::nextSibling() const

void AXNodeObject::addChildren()

{

+ ASSERT(!isDetached());

// If the need to add more children in addition to existing children arises,

// childrenChanged should have been called, leaving the object with no children.

ASSERT(!m_haveChildren);