Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Side by Side Diff: third_party/WebKit/Source/modules/accessibility/AXTableHeaderContainer.cpp

Issue 1207613004: Fix leaking AXNodeObjects when sub document detaches (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebased Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/accessibility/AXTableColumn.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 return false; 62 return false;
63 63
64 if (ignoredReasons) 64 if (ignoredReasons)
65 m_parent->computeAccessibilityIsIgnored(ignoredReasons); 65 m_parent->computeAccessibilityIsIgnored(ignoredReasons);
66 66
67 return true; 67 return true;
68 } 68 }
69 69
70 void AXTableHeaderContainer::addChildren() 70 void AXTableHeaderContainer::addChildren()
71 { 71 {
72 ASSERT(!isDetached());
72 ASSERT(!m_haveChildren); 73 ASSERT(!m_haveChildren);
73 74
74 m_haveChildren = true; 75 m_haveChildren = true;
75 if (!m_parent || !m_parent->isAXTable()) 76 if (!m_parent || !m_parent->isAXTable())
76 return; 77 return;
77 78
78 toAXTable(m_parent)->columnHeaders(m_children); 79 toAXTable(m_parent)->columnHeaders(m_children);
79 80
80 unsigned length = m_children.size(); 81 unsigned length = m_children.size();
81 for (unsigned k = 0; k < length; ++k) 82 for (unsigned k = 0; k < length; ++k)
82 m_headerRect.unite(m_children[k]->elementRect()); 83 m_headerRect.unite(m_children[k]->elementRect());
83 } 84 }
84 85
85 } // namespace blink 86 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/modules/accessibility/AXTableColumn.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698