Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: third_party/WebKit/Source/modules/accessibility/AXARIAGrid.cpp

Issue 1207613004: Fix leaking AXNodeObjects when sub document detaches (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebased Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2009 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 m_children.append(row); 74 m_children.append(row);
75 else 75 else
76 m_children.appendVector(row->children()); 76 m_children.appendVector(row->children());
77 77
78 appendedRows.add(row); 78 appendedRows.add(row);
79 return true; 79 return true;
80 } 80 }
81 81
82 void AXARIAGrid::addChildren() 82 void AXARIAGrid::addChildren()
83 { 83 {
84 ASSERT(!isDetached());
84 ASSERT(!m_haveChildren); 85 ASSERT(!m_haveChildren);
85 86
86 if (!isAXTable()) { 87 if (!isAXTable()) {
87 AXLayoutObject::addChildren(); 88 AXLayoutObject::addChildren();
88 return; 89 return;
89 } 90 }
90 91
91 m_haveChildren = true; 92 m_haveChildren = true;
92 if (!m_layoutObject) 93 if (!m_layoutObject)
93 return; 94 return;
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 if (!column->accessibilityIsIgnored()) 126 if (!column->accessibilityIsIgnored())
126 m_children.append(column); 127 m_children.append(column);
127 } 128 }
128 129
129 AXObject* headerContainerObject = headerContainer(); 130 AXObject* headerContainerObject = headerContainer();
130 if (headerContainerObject && !headerContainerObject->accessibilityIsIgnored( )) 131 if (headerContainerObject && !headerContainerObject->accessibilityIsIgnored( ))
131 m_children.append(headerContainerObject); 132 m_children.append(headerContainerObject);
132 } 133 }
133 134
134 } // namespace blink 135 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/dom/Document.cpp ('k') | third_party/WebKit/Source/modules/accessibility/AXImageMapLink.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698