Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 1207613003: X87: Do not add extra argument for new.target. (Closed)

Created:
5 years, 6 months ago by chunyang.dai
Modified:
5 years, 5 months ago
Reviewers:
Weiliang
CC:
v8-dev, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Do not add extra argument for new.target. port 8196c28a94f62dec026f2b564ba81d690a4ed593 (r29238). original commit message: JSConstructStub for subclass constructors instead locates new.target in a known location on the stack. BUG= Committed: https://crrev.com/18d27f19359bd76a4818e9a13ae67bebfc3cd012 Cr-Commit-Position: refs/heads/master@{#29398}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -39 lines) Patch
M src/x87/builtins-x87.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 4 chunks +0 lines, -17 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 6 chunks +26 lines, -18 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 5 months ago (2015-06-30 09:14:36 UTC) #2
Weiliang
lgtm
5 years, 5 months ago (2015-07-01 01:26:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1207613003/1
5 years, 5 months ago (2015-07-01 01:26:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-01 01:57:23 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-01 01:57:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/18d27f19359bd76a4818e9a13ae67bebfc3cd012
Cr-Commit-Position: refs/heads/master@{#29398}

Powered by Google App Engine
This is Rietveld 408576698