Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: components/bookmarks/browser/bookmark_model.cc

Issue 1207603002: Remove check whether BookmarkModel::store_ has been initialized in BookmarkModel::OnFaviconChanged() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/bookmarks/browser/bookmark_model.cc
diff --git a/components/bookmarks/browser/bookmark_model.cc b/components/bookmarks/browser/bookmark_model.cc
index cf969748c6fb5b5751c50bfade02a6d224f790d7..86fd29f247c5ddf68f9f8e200c2d4c3f1e5618d0 100644
--- a/components/bookmarks/browser/bookmark_model.cc
+++ b/components/bookmarks/browser/bookmark_model.cc
@@ -435,10 +435,6 @@ void BookmarkModel::SetNodeSyncTransactionVersion(
}
void BookmarkModel::OnFaviconChanged(const std::set<GURL>& urls) {
- // Ignore events if |Load| has not been called yet.
- if (!store_)
- return;
-
// Prevent the observers from getting confused for multiple favicon loads.
for (std::set<GURL>::const_iterator i = urls.begin(); i != urls.end(); ++i) {
std::vector<const BookmarkNode*> nodes;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698