Remove check whether BookmarkModel::store_ has been initialized in BookmarkModel::OnFaviconChanged()

Remove check whether |BookmarkModel::store_| has been initialized in BookmarkModel::OnFaviconChanged()

The purpose of this CL is to make testing BookmarkModel::OnFaviconChanged()
easier.

BUG=485657
TEST=None

Committed: https://crrev.com/236fbee8c2ad41a41149aacfa0f628b0c53eb512
Cr-Commit-Position: refs/heads/master@{#336206}

[pkotwicz, 2015-06-24 18:34:05]

pkotwicz@chromium.org changed reviewers:
+ sdefresne@chromium.org

[pkotwicz, 2015-06-24 18:41:04]

sdefresne@ can you please take a look?

The check for the presence of |BookmarkModel::store_| was added in Patch Set #9
in https://codereview.chromium.org/242693003/#ps150001 I am unsure whether the
check was added to better mimic the behavior without the patch or because the
check is necessary.
My understanding is that the check should not matter in production. I have not
found a test where the check matters.

[sdefresne, 2015-06-25 08:50:50]

On 2015/06/24 at 18:41:04, pkotwicz wrote:
> sdefresne@ can you please take a look?
> 
> The check for the presence of |BookmarkModel::store_| was added in Patch Set
#9 in https://codereview.chromium.org/242693003/#ps150001 I am unsure whether
the check was added to better mimic the behavior without the patch or because
the check is necessary.
> My understanding is that the check should not matter in production. I have not
found a test where the check matters.

The test was added to mimic the behaviour without the patch (as the registration
to listen to chrome::NOTIFICATION_FAVICON_CHANGED event was done once the
BookmarkModel store has finished loading). The goal of the pointed patch was to
not introduce any functional change while migrating from using content
notification to using the observer pattern.

[sdefresne, 2015-06-25 08:52:04]

sdefresne@chromium.org changed reviewers:
+ sky@chromium.org

[sdefresne, 2015-06-25 08:52:04]

lgtm but please wait for sky@ review who know the BookmarkModel much better than
I do and can probably tell you whether this check is required or not.

[sky, 2015-06-25 16:46:26]

I believe this was only for testing. So, if it's not necessary anymore it can be
nuked. LGTM

[pkotwicz, 2015-06-25 17:35:29]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2015-06-25 17:35:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1207603002/1

[commit-bot: I haz the power, 2015-06-25 18:26:54]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-06-25 18:27:44]

Patchset 1 (id:??) landed as
https://crrev.com/236fbee8c2ad41a41149aacfa0f628b0c53eb512
Cr-Commit-Position: refs/heads/master@{#336206}