Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 1207593006: Removing unused functions from ResourceRequest class (Closed)

Created:
5 years, 6 months ago by shiva.jm
Modified:
5 years, 6 months ago
Reviewers:
pdr., Mike West
CC:
Habib Virji
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Removing unused functions from ResourceRequest class This patch removes the following unused function: ResourceRequest::clearHTTPAuthorization(), ResourceRequest::defaultTimeoutInterval(), ResourceRequest::setDefaultTimeoutInterval(), initializeMaximumHTTPConnectionCountPerHost() BUG=439559 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197727

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -31 lines) Patch
M Source/platform/network/ResourceRequest.h View 3 chunks +0 lines, -7 lines 0 comments Download
M Source/platform/network/ResourceRequest.cpp View 3 chunks +0 lines, -24 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
shiva.jm
pls have a look.
5 years, 6 months ago (2015-06-24 07:00:46 UTC) #2
Mike West
On 2015/06/24 at 07:00:46, shiva.jm wrote: > pls have a look. LGTM if everything compiles.
5 years, 6 months ago (2015-06-24 07:12:23 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1207593006/1
5 years, 6 months ago (2015-06-24 07:13:15 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-24 09:56:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1207593006/1
5 years, 6 months ago (2015-06-24 09:58:31 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 10:02:38 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197727

Powered by Google App Engine
This is Rietveld 408576698