Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 1207553004: Turning off effects for audio modem recording. (Closed)

Created:
5 years, 6 months ago by Charlie
Modified:
5 years, 6 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, Boris Smus
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Turning off effects for audio modem recording. Context: b/19978960 Committed: https://crrev.com/2ef7254ed6d040ab77e31a6e27bf10b2a51117f2 Cr-Commit-Position: refs/heads/master@{#335830}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M components/audio_modem/audio_recorder_impl.cc View 1 chunk +13 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Charlie
Hey Dale, Should this resolve the audio ducking issue in b/19978960? - Charlie
5 years, 6 months ago (2015-06-23 23:49:00 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1207553004/1
5 years, 6 months ago (2015-06-23 23:49:56 UTC) #4
DaleCurtis
Seems likely to, lgtm
5 years, 6 months ago (2015-06-23 23:53:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1207553004/1
5 years, 6 months ago (2015-06-24 00:13:44 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-24 00:43:10 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 00:44:05 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2ef7254ed6d040ab77e31a6e27bf10b2a51117f2
Cr-Commit-Position: refs/heads/master@{#335830}

Powered by Google App Engine
This is Rietveld 408576698